From: Christoph Hellwig <hch@lst.de>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/4] PS3: Move system bus to platform directory
Date: Wed, 31 Jan 2007 09:49:46 +0100 [thread overview]
Message-ID: <20070131084946.GD5596@lst.de> (raw)
In-Reply-To: <45BFD2BB.1030008@am.sony.com>
On Tue, Jan 30, 2007 at 03:20:27PM -0800, Geoff Levand wrote:
> @@ -22,6 +22,9 @@
> #define _PS3_PLATFORM_H
>
> #include <linux/rtc.h>
> +#include <scsi/scsi.h>
> +enum ps3_dev_type {
> + PS3_DEV_TYPE_STOR_DISK = TYPE_DISK, /* 0 */
> + PS3_DEV_TYPE_SB_GELIC = 3,
> + PS3_DEV_TYPE_SB_USB = 4,
> + PS3_DEV_TYPE_STOR_ROM = TYPE_ROM, /* 5 */
> + PS3_DEV_TYPE_SB_GPIO = 6,
> + PS3_DEV_TYPE_STOR_FLASH = TYPE_RBC, /* 14 */
> +};
I don't think you should take some of the values from the scsi device
types but reuse others. Just do an enum of your own and if you ever
have to translate to scsi types somewhere use a lookup table.
next prev parent reply other threads:[~2007-01-31 8:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 23:20 [PATCH 1/4] PS3: Move system bus to platform directory Geoff Levand
2007-01-30 23:25 ` Benjamin Herrenschmidt
2007-01-31 8:49 ` Christoph Hellwig [this message]
2007-01-31 9:46 ` Geert Uytterhoeven
2007-02-06 13:23 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070131084946.GD5596@lst.de \
--to=hch@lst.de \
--cc=geoffrey.levand@am.sony.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).