From: David Gibson <david@gibson.dropbear.id.au>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH] Missing ifndef __ASSEMBLY__ in include/asm-powerpc/dcr.h
Date: Tue, 6 Feb 2007 10:56:39 +1100 [thread overview]
Message-ID: <20070205235639.GB20123@localhost.localdomain> (raw)
In-Reply-To: <20070205193310.GA12412@Krystal>
On Mon, Feb 05, 2007 at 02:33:10PM -0500, Mathieu Desnoyers wrote:
> Missing ifndef __ASSEMBLY__ in include/asm-powerpc/dcr.h
>
> A missing structure forward declaration causes a lot of warnings when
> compiling for a powerpc 405. Because this header is used for assembly
> too, the declaration must be put within #ifndef __ASSEMBLY__, as should
> be the function prototypes.
>
> This patch applies on 2.6.20.
This is the wrong fix. The arch/powerpc version of dcr.h, unlike the
arch/ppc version, should never be included in assembler.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
prev parent reply other threads:[~2007-02-05 23:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-05 19:33 [PATCH] Missing ifndef __ASSEMBLY__ in include/asm-powerpc/dcr.h Mathieu Desnoyers
2007-02-05 20:18 ` Benjamin Herrenschmidt
2007-02-05 20:21 ` Mathieu Desnoyers
2007-02-05 23:56 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070205235639.GB20123@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).