From: Christoph Hellwig <hch@lst.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>,
linuxppc-dev@ozlabs.org, cbe-oss-dev@ozlabs.org,
Arnd Bergmann <arnd.bergmann@de.ibm.com>
Subject: Re: [Cbe-oss-dev] [PATCH 3/3] spufs: remove need for struct page for SPEs
Date: Wed, 7 Feb 2007 15:52:26 +0100 [thread overview]
Message-ID: <20070207145226.GA14458@lst.de> (raw)
In-Reply-To: <20070207045055.295F3DDE46@ozlabs.org>
On Wed, Feb 07, 2007 at 03:50:52PM +1100, Benjamin Herrenschmidt wrote:
> This patch removes the need for struct page for SPE local store
> and registers from spufs. It also makes the locking much more
> obvious and no longer relying on the truncate logic black magic
> for protecting against races between unmap_mapping_range() and
> new pages faulted in. It does so by switching to a nopfn() handler
> and using the new vm_insert_pfn() to setup the PTEs itself while
> holding a lock on the SPE.
>
> The nice thing is that this patch actually removes a lot more code
> than it adds :-)
Looks good to me.
next prev parent reply other threads:[~2007-02-07 14:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-07 4:50 [PATCH 0/3] spufs: don't need struct page for SPEs Benjamin Herrenschmidt
2007-02-07 4:50 ` [PATCH 1/3] add vm_insert_pfn() Benjamin Herrenschmidt
2007-02-07 4:50 ` [PATCH 2/3] Add NOPFN_REFAULT result from vm_ops->nopfn() Benjamin Herrenschmidt
2007-02-07 4:50 ` [PATCH 3/3] spufs: remove need for struct page for SPEs Benjamin Herrenschmidt
2007-02-07 4:55 ` Benjamin Herrenschmidt
2007-02-07 14:52 ` Christoph Hellwig [this message]
2007-02-07 22:21 ` Andrew Morton
2007-02-07 23:15 ` Benjamin Herrenschmidt
2007-02-09 3:59 ` [Cbe-oss-dev] " Benjamin Herrenschmidt
2007-02-07 14:39 ` [PATCH 0/3] spufs: don't need " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070207145226.GA14458@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=arnd.bergmann@de.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=cbe-oss-dev@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).