From: olof@lixom.net (Olof Johansson)
To: Manish Ahuja <ahuja@austin.ibm.com>
Cc: ppc-dev <linuxppc-dev@ozlabs.org>, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH]Enabling Auto poweron after power is restored.
Date: Wed, 7 Feb 2007 10:59:01 -0600 [thread overview]
Message-ID: <20070207165901.GA974@lixom.net> (raw)
In-Reply-To: <45C40C97.807@austin.ibm.com>
On Fri, Feb 02, 2007 at 10:16:23PM -0600, Manish Ahuja wrote:
> Resubmitting this patch with a sysfs interface instead of /proc.
> During some off line discussion, /sys/power was suggested as a possible
> candidate area for this functionality to reside.
Minor nitpick since you have to respin based on Paul's comments anyway...
> void rtas_power_off(void)
> {
> + int rc;
> + int rtas_poweroff_ups_token = rtas_token("ibm,power-off-ups");
> +
> if (rtas_flash_term_hook)
> - rtas_flash_term_hook(SYS_POWER_OFF);
> - /* allow power on only with power button press */
> - printk("RTAS power-off returned %d\n",
> - rtas_call(rtas_token("power-off"), 2, 1, NULL, -1, -1));
> + rtas_flash_term_hook(SYS_POWER_OFF);
Looks like you have an if (rtas_flash_term_hook) with an unindented line
right after it.
-Olof
next prev parent reply other threads:[~2007-02-07 16:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 18:28 [PATCH]Enabling Auto poweron after power is restored Manish Ahuja
2006-12-04 15:48 ` Will Schmidt
2006-12-04 19:31 ` Linas Vepstas
2006-12-04 19:49 ` Olof Johansson
2006-12-04 21:26 ` Manish Ahuja
2006-12-05 21:41 ` Manish Ahuja
2006-12-08 6:09 ` Paul Mackerras
2006-12-24 16:56 ` Manish Ahuja
2006-12-24 17:50 ` Manish Ahuja
2007-01-09 4:16 ` Paul Mackerras
2007-01-09 14:21 ` Segher Boessenkool
2007-01-09 15:05 ` Nathan Lynch
2007-01-10 20:58 ` Linas Vepstas
2007-01-10 20:58 ` Manish Ahuja
2007-01-12 0:38 ` Linas Vepstas
2007-02-03 4:16 ` Manish Ahuja
2007-02-06 17:58 ` Linas Vepstas
2007-02-07 2:24 ` Paul Mackerras
2007-02-07 19:42 ` Manish Ahuja
2007-02-08 22:01 ` Manish Ahuja
2007-02-07 16:59 ` Olof Johansson [this message]
2007-02-07 17:05 ` Manish Ahuja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070207165901.GA974@lixom.net \
--to=olof@lixom.net \
--cc=ahuja@austin.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).