From: Pavel Machek <pavel@ucw.cz>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
linuxppc-dev@ozlabs.org, linux-pm@lists.osdl.org
Subject: Re: [PATCH 05/12] power management: no valid states w/o pm_ops + docs
Date: Tue, 13 Feb 2007 13:12:49 +0100 [thread overview]
Message-ID: <20070213121249.GJ18101@elf.ucw.cz> (raw)
In-Reply-To: <20070207124612.176570000@sipsolutions.net>
Hi!
> This patch changes /sys/power/state to not advertise any valid states
> (except for disk if SOFTWARE_SUSPEND is enabled) when no pm_ops have been
> set so userspace can easily discover what states should be available.
>
> Also, because the pm ops in powermac are obviously not using them as
> intended, I added documentation for it in kernel-doc format.
>
> Reordering the fields in struct pm_ops not only makes the output of
> kernel-doc make more sense but also removes a hole from the structure on
> 64-bit platforms.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Cc: linux-pm@lists.osdl.org
> Cc: Rafael J. Wysocki <rjw@sisk.pl>
> Cc: Pavel Macheck <pavel@ucw.cz>
Looks okay to me.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-02-13 12:34 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-07 12:45 [PATCH 00/12] powerpc/powermac power management patches Johannes Berg
2007-02-07 12:45 ` [PATCH 01/12] powerpc: MPIC sys_device & suspend/resume Johannes Berg
2007-02-07 12:45 ` [PATCH 02/12] powermac: support G5 CPU hotplug Johannes Berg
2007-02-08 13:14 ` Johannes Berg
2007-02-08 13:28 ` Johannes Berg
2007-02-08 15:38 ` Johannes Berg
2007-02-08 21:59 ` [linux-pm] " Paul Mackerras
2007-02-08 22:33 ` Benjamin Herrenschmidt
2007-02-09 15:39 ` Johannes Berg
2007-02-08 22:24 ` Benjamin Herrenschmidt
2007-02-08 22:24 ` Benjamin Herrenschmidt
2007-02-09 15:36 ` Johannes Berg
2007-02-12 15:15 ` Johannes Berg
2007-02-15 3:44 ` Paul Mackerras
2007-02-15 15:08 ` Johannes Berg
2007-02-15 19:43 ` Johannes Berg
2007-02-14 14:45 ` [linux-pm] " Pavel Machek
2007-02-14 19:11 ` Johannes Berg
2007-02-14 21:27 ` Benjamin Herrenschmidt
2007-02-07 12:45 ` [PATCH 03/12] powerpc: dart iommu suspend Johannes Berg
2007-02-07 12:45 ` [PATCH 04/12] powerpc: mark pages that dont exist as Nosave Johannes Berg
2007-02-07 12:45 ` [PATCH 05/12] power management: no valid states w/o pm_ops + docs Johannes Berg
2007-02-13 12:12 ` Pavel Machek [this message]
2007-02-13 16:08 ` Johannes Berg
2007-02-13 16:14 ` Pavel Machek
2007-02-07 12:45 ` [PATCH 06/12] powerpc: fix suspend states again Johannes Berg
2007-02-07 12:45 ` [PATCH 07/12] powermac: suspend to disk on G5 Johannes Berg
2007-02-07 12:45 ` [PATCH 08/12] powermac: fix G5-cpufreq for cpu on/offline Johannes Berg
2007-02-07 12:45 ` [PATCH 09/12] powerpc: remove bogus comment about page_is_ram Johannes Berg
2007-02-07 12:45 ` [PATCH 10/12] powerpc: remove unneeded exports in mem.c Johannes Berg
2007-02-08 4:25 ` Paul Mackerras
2007-02-08 13:10 ` Johannes Berg
2007-02-08 13:27 ` [PATCH 10/12] powerpc: remove unneeded page_is_ram export Johannes Berg
2007-02-07 12:45 ` [PATCH 11/12] powermac: disallow pmu sleep notifiers from aborting sleep Johannes Berg
2007-02-07 22:52 ` Andreas Schwab
2007-02-08 13:08 ` Johannes Berg
2007-02-08 13:16 ` Johannes Berg
2007-02-07 12:45 ` [PATCH 12/12] powermac: proper sleep management Johannes Berg
2007-02-08 13:16 ` [PATCH 13/12] mpic: add affinity callback for IPI "chip" Johannes Berg
2007-02-08 21:14 ` Benjamin Herrenschmidt
2007-02-09 15:41 ` Johannes Berg
2007-02-12 15:20 ` [PATCH 13/12] mpic: set IPIs to be per-CPU Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070213121249.GJ18101@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=johannes@sipsolutions.net \
--cc=linux-pm@lists.osdl.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).