From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 14 Feb 2007 12:33:30 +1100 From: David Gibson To: Kumar Gala Subject: Re: [PATCH] ppc: Add support for AMCC Taishan 440GX eval board Message-ID: <20070214013330.GH11491@localhost.localdomain> References: <1171281988.20192.1.camel@localhost.localdomain> <1171310108.20192.7.camel@localhost.localdomain> <1171311802.20192.15.camel@localhost.localdomain> <20070213004608.GB4894@localhost.localdomain> <8DEFFE52-2326-43A9-9719-15E04EF17D3A@kernel.crashing.org> <20070214001106.GA11491@localhost.localdomain> <154265F9-EBB3-4BE4-9AD1-3E09BDD9F237@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <154265F9-EBB3-4BE4-9AD1-3E09BDD9F237@kernel.crashing.org> Cc: linuxppc-dev@ozlabs.org, Jon Loeliger , Stefan Roese , Roland Dreier , linuxppc-embedded@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Feb 13, 2007 at 06:30:40PM -0600, Kumar Gala wrote: > > On Feb 13, 2007, at 6:11 PM, David Gibson wrote: > > > On Mon, Feb 12, 2007 at 11:28:17PM -0600, Kumar Gala wrote: > >> > >> On Feb 12, 2007, at 6:46 PM, David Gibson wrote: > >> > >>> On Mon, Feb 12, 2007 at 02:41:36PM -0600, Kumar Gala wrote: > >>>> > >>>> On Feb 12, 2007, at 2:23 PM, Benjamin Herrenschmidt wrote: > >>>> > >>>>> On Mon, 2007-02-12 at 14:16 -0600, Jon Loeliger wrote: > >>>>>> So, like, the other day Benjamin Herrenschmidt mumbled: > >>>>>>> > >>>>>>> Note that there are still things that we might want to > >>>>>>> change. For > >>>>>>> example, I think we really should look into adding a macro > >>>>>>> mecanism > >>>>>>> and/or an include mecanism to dtc so that we can do things like > >>>>>>> #include > >>>>>>> to get the base processor/SoC definition and then > >>>>>>> "overlay" some properties on top of it (like emac phy mode > >>>>>>> etc...) > >>>>>> > >>>>>> What do people prefer here? Straight CPP pre-run? > >>>>> > >>>>> CPP pre-run has issue, notably due to the usage of "#" in property > >>>>> names. > >>>> > >>>> You can get around that by invoking cpp with the right flags, I > >>>> looked at doing this a while back and had it working. > >>> > >>> Umm.. which flags? > >> > >> cpp -undef -P -x assembler-with-cpp > > > > What exactly does the -x assembler-with-cpp do? I can't seem to find > > a useful description in the man page or info. > > I think it treats the input as if where of assembler syntax. And > thus # has special meaning in some places. Yes... what places, precisely. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson