Re: undefined symbol 'PS3_PS3AV'

Re: undefined symbol 'PS3_PS3AV'

[Geert Uytterhoeven]

On Wed, 14 Feb 2007, Thomas Meyer wrote:
> with 93bbad8fe13a25dcf7f3bc628a71d1a7642ae61b:
> 
> drivers/video/Kconfig:1604:warning: 'select' used by config symbol 'FB_PS3'
> refer to undefined symbol 'PS3_PS3AV'

It's defined in arch/powerpc/platforms/ps3/Kconfig, which is sourced by
arch/powerpc/Kconfig only.

I don't know what's the best way to shut this up. Anyone with a suggestion?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium

Re: undefined symbol 'PS3_PS3AV'

[Paul Mundt]

On Wed, Feb 14, 2007 at 09:57:46AM +0100, Geert Uytterhoeven wrote:
> On Wed, 14 Feb 2007, Thomas Meyer wrote:
> > with 93bbad8fe13a25dcf7f3bc628a71d1a7642ae61b:
> > 
> > drivers/video/Kconfig:1604:warning: 'select' used by config symbol 'FB_PS3'
> > refer to undefined symbol 'PS3_PS3AV'
> 
> It's defined in arch/powerpc/platforms/ps3/Kconfig, which is sourced by
> arch/powerpc/Kconfig only.
> 
> I don't know what's the best way to shut this up. Anyone with a suggestion?
> 
This would seem like a reasonable candidate for a 'depends on' instead of
a select..

Re: undefined symbol 'PS3_PS3AV'

[Geert Uytterhoeven]

On Wed, 14 Feb 2007, Paul Mundt wrote:
> On Wed, Feb 14, 2007 at 09:57:46AM +0100, Geert Uytterhoeven wrote:
> > On Wed, 14 Feb 2007, Thomas Meyer wrote:
> > > with 93bbad8fe13a25dcf7f3bc628a71d1a7642ae61b:
> > > 
> > > drivers/video/Kconfig:1604:warning: 'select' used by config symbol 'FB_PS3'
> > > refer to undefined symbol 'PS3_PS3AV'
> > 
> > It's defined in arch/powerpc/platforms/ps3/Kconfig, which is sourced by
> > arch/powerpc/Kconfig only.
> > 
> > I don't know what's the best way to shut this up. Anyone with a suggestion?
> > 
> This would seem like a reasonable candidate for a 'depends on' instead of
> a select..

That's what we originally had. But for the user it's simler if he can just
enable ps3fb and/or ps3snd (sound driver not yet finished), which both select
PS3_PS3AV.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium

Re: undefined symbol 'PS3_PS3AV'

[Paul Mundt]

On Wed, Feb 14, 2007 at 11:02:06AM +0100, Geert Uytterhoeven wrote:
> On Wed, 14 Feb 2007, Paul Mundt wrote:
> > This would seem like a reasonable candidate for a 'depends on' instead of
> > a select..
> 
> That's what we originally had. But for the user it's simler if he can just
> enable ps3fb and/or ps3snd (sound driver not yet finished), which both select
> PS3_PS3AV.

Why not just have PS3_PS3AV def_bool y if ps3fb || ps3snd? Or if that
doesn't work, just place the PS3FB option in arch/powerpc/platforms/ps3/Kconfig.

Of course if select obeyed the depends on, this wouldn't be a problem
either..

Re: undefined symbol 'PS3_PS3AV'

[Benjamin Herrenschmidt]

On Wed, 2007-02-14 at 19:17 +0900, Paul Mundt wrote:
> On Wed, Feb 14, 2007 at 11:02:06AM +0100, Geert Uytterhoeven wrote:
> > On Wed, 14 Feb 2007, Paul Mundt wrote:
> > > This would seem like a reasonable candidate for a 'depends on' instead of
> > > a select..
> > 
> > That's what we originally had. But for the user it's simler if he can just
> > enable ps3fb and/or ps3snd (sound driver not yet finished), which both select
> > PS3_PS3AV.
> 
> Why not just have PS3_PS3AV def_bool y if ps3fb || ps3snd? Or if that
> doesn't work, just place the PS3FB option in arch/powerpc/platforms/ps3/Kconfig.
> 
> Of course if select obeyed the depends on, this wouldn't be a problem
> either..

I'd rather fix Kconfig to do the later...

Ben.