From: Hoang-Nam Nguyen <hnguyen@linux.vnet.ibm.com>
To: paulus@samba.org, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org, johnrose@us.ibm.com,
Sylvain Munaut <tnt@246tnt.com>
Cc: fenkes@de.ibm.com, pmac@au1.ibm.com
Subject: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus
Date: Sat, 17 Feb 2007 17:28:15 +0100 [thread overview]
Message-ID: <200702171728.15597.hnguyen@linux.vnet.ibm.com> (raw)
ibmebus has a fake root device that's not associated with an ofdt node.
Filter out any such devices in of_device_uevent().
Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com>
---
of_device.c | 4 ++++
1 files changed, 4 insertions(+)
diff -urp a/arch/powerpc/kernel/of_device.c b/arch/powerpc/kernel/of_device.c
--- a/arch/powerpc/kernel/of_device.c 2007-02-17 16:36:32.116368480 +0100
+++ b/arch/powerpc/kernel/of_device.c 2007-02-17 16:44:01.319366352 +0100
@@ -180,6 +180,10 @@ int of_device_uevent(struct device *dev,
ofdev = to_of_device(dev);
+ /* e.g. ibmebus has a fake root device w/o ofdt node -- filter that */
+ if (!ofdev->node)
+ return -ENODEV;
+
if (add_uevent_var(envp, num_envp, &i,
buffer, buffer_size, &length,
"OF_NAME=%s", ofdev->node->name))
next reply other threads:[~2007-02-17 16:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-17 16:28 Hoang-Nam Nguyen [this message]
2007-02-17 21:56 ` [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus Benjamin Herrenschmidt
2007-02-18 0:21 ` Joachim Fenkes
2007-02-18 0:37 ` Benjamin Herrenschmidt
2007-02-19 16:36 ` Joachim Fenkes
2007-02-19 19:47 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702171728.15597.hnguyen@linux.vnet.ibm.com \
--to=hnguyen@linux.vnet.ibm.com \
--cc=fenkes@de.ibm.com \
--cc=johnrose@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=pmac@au1.ibm.com \
--cc=tnt@246tnt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).