From: David Gibson <david@gibson.dropbear.id.au>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 19/19] bootwrapper: compatibility layer for old U-Boots (a.k.a. cuImage, cuboot)
Date: Sun, 18 Feb 2007 11:22:20 +1100 [thread overview]
Message-ID: <20070218002220.GB29434@localhost.localdomain> (raw)
In-Reply-To: <45D1F61B.6020104@am.sony.com>
On Tue, Feb 13, 2007 at 09:32:11AM -0800, Geoff Levand wrote:
> Scott Wood wrote:
> >> It may be better to do it like this, as there will be more platforms that
> >> need to hook in specific files.
> >>
> >> src-plat-$(CONFIG_COMPAT_UIMAGE) += $(cuboot-plats:%=cuboot-%.c)
> >> src-plat-$(CONFIG_XXX) += ...
> >> src-plat-$(CONFIG_YYY) += ...
> >> ...
> >> src-plat := of.c $(src-plat-y)
> >
> > Take it up with Paul. He said that all platform files shall always be
> > built, and that the wrapper script picks which ones to link.
>
>
> That is what this sets up, for all platforms the kernel is built to support,
> all the corresponding wrapperbits are built.
>
> The problem I see with what you have done is that if there is a single bug in the
> wrapperbits for any platform, all zImage builds for ANY platform will fail, even
> platforms the kernel is not configured to support.
>
> I think most people only build for a few platforms and would not want to
> be inconvenienced buy a bug in a platform they have no interest in, and
> in general, I don't think platform maintainers want to inconvenience people
> with platform specific bugs when they are not building for that platform.
On the other hand, this property means it's far less likely that
people will break platforms they're not actively working on at the
time.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-02-18 0:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 20:54 [PATCH 19/19] bootwrapper: compatibility layer for old U-Boots (a.k.a. cuImage, cuboot) Scott Wood
2007-02-12 21:38 ` Geoff Levand
2007-02-13 16:13 ` Scott Wood
2007-02-13 17:32 ` Geoff Levand
2007-02-18 0:22 ` David Gibson [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-02-07 23:00 [PATCH 00/19] cuboot bootwrapper patchset Scott Wood
2007-02-07 23:01 ` [PATCH 19/19] bootwrapper: compatibility layer for old U-Boots (a.k.a. cuImage, cuboot) Scott Wood
2007-02-08 21:15 ` David Gibson
2007-02-09 17:11 ` Scott Wood
2007-02-10 1:02 ` David Gibson
2007-02-12 16:52 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070218002220.GB29434@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=geoffrey.levand@am.sony.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).