linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 3/3] zImage: Cleanup and improve zImage entry point
Date: Mon, 19 Feb 2007 11:48:44 +1100	[thread overview]
Message-ID: <20070219004844.GB6864@localhost.localdomain> (raw)
In-Reply-To: <17880.61080.644756.499806@cargo.ozlabs.ibm.com>

On Mon, Feb 19, 2007 at 11:26:00AM +1100, Paul Mackerras wrote:
> David Gibson writes:
> 
> > Err... isn't the called function responsible for setting up its own
> > stack frame if necessary.  I thought all that was needed was for r1 to
> > point to some free space.
> 
> The called function stores its return address in the caller's stack
> frame.  So r1 does need to point to a stack frame.

Ah, ok.  Fixing that now.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  reply	other threads:[~2007-02-19  0:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-16  6:24 [0/3] RFC: Cleanups and improvements to the zImage wrapper David Gibson
2007-02-16  6:27 ` [PATCH 1/3] zImage: Add more flexible gunzip convenience functions David Gibson
2007-02-16  6:27 ` [PATCH 2/3] zImage: Cleanup and improve prep_kernel() David Gibson
2007-02-18  1:22   ` Geoff Levand
2007-02-18  7:21     ` David Gibson
2007-02-16  6:27 ` [PATCH 3/3] zImage: Cleanup and improve zImage entry point David Gibson
2007-02-18  1:22   ` Geoff Levand
2007-02-18  7:23     ` David Gibson
2007-02-19  0:26       ` Paul Mackerras
2007-02-19  0:48         ` David Gibson [this message]
2007-02-19 15:14       ` Geoff Levand
2007-02-19 19:59         ` Benjamin Herrenschmidt
2007-02-19 19:57     ` Benjamin Herrenschmidt
2007-02-19 20:37       ` Geoff Levand
2007-02-19 20:50         ` Benjamin Herrenschmidt
2007-02-19 21:14           ` Geoff Levand
2007-02-16 16:47 ` [0/3] RFC: Cleanups and improvements to the zImage wrapper Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070219004844.GB6864@localhost.localdomain \
    --to=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).