From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 21 Feb 2007 11:19:18 +1100 From: David Gibson To: Sergei Shtylyov Subject: Re: [PATCH 4/14] Use resource_size_t for serial port IO addresses Message-ID: <20070221001918.GC10231@localhost.localdomain> References: <20070220021234.E27E2DDD0B@ozlabs.org> <45DB094A.2040309@ru.mvista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <45DB094A.2040309@ru.mvista.com> Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Feb 20, 2007 at 05:44:26PM +0300, Sergei Shtylyov wrote: > Hello. > > David Gibson wrote: > > At present, various parts of the serial code use unsigned long to > > define resource addresses. This is a problem, because some 32-bit > > platforms have physical addresses larger than 32-bits, and have mmio > > serial uarts located above the 4GB point. > > > > This patch changes the type of mapbase in both struct uart_port and > > struct plat_serial8250_port to resource_size_t, which can be > > configured to be 64 bits on such platforms. The mapbase in > > serial_struct can't safely be changed, because that structure is user > > visible. > > Erm, isn't linux-serial@vger.kernel.org more proper list for > such patches? Also, as serial drivers are now unmaintained, this > probably needs to go to -mm tree. I've also sent this to rmk, akpm and lkml for inclusion in -mm. It's just copied here so that all the patches necessary for Ebony are convenient in one place. > > Index: working-2.6/drivers/serial/serial_core.c > > =================================================================== > > --- working-2.6.orig/drivers/serial/serial_core.c 2007-02-19 11:07:42.000000000 +1100 > > +++ working-2.6/drivers/serial/serial_core.c 2007-02-19 11:07:43.000000000 +1100 > > @@ -633,7 +633,7 @@ static int uart_get_info(struct uart_sta > > tmp.hub6 = port->hub6; > > tmp.io_type = port->iotype; > > tmp.iomem_reg_shift = port->regshift; > > - tmp.iomem_base = (void *)port->mapbase; > > + tmp.iomem_base = (void *)(unsigned long)port->mapbase; > > For 32-bit kernels this may result in a meaningless address. Have you > considered also changing iomem_base's type? Impossible; that's the serial_struct, which is userland visible. Yes, it will result in a meaningless address, but I don't see what else can be done. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson