From: David Gibson <david@gibson.dropbear.id.au>
To: Jon Loeliger <jdl@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: [dtc] Fix flat_dt_property structure
Date: Mon, 26 Feb 2007 11:02:24 +1100 [thread overview]
Message-ID: <20070226000224.GB29826@localhost.localdomain> (raw)
The structure in flat_dt.h defining the layout of a proprety within
the flat device tree is incorrect. It has the offset to the
property's name, then the length when in fact (according to
booting-without-of.txt and the output of dtc) then length should come
first, followed by the name offset.
In fact, this structure is never used so the mistake doesn't break
anything, but it should still be fixed to avoid misleading people.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Index: dtc/flat_dt.h
===================================================================
--- dtc.orig/flat_dt.h 2007-02-26 10:59:03.000000000 +1100
+++ dtc/flat_dt.h 2007-02-26 10:59:45.000000000 +1100
@@ -37,8 +37,8 @@ struct reserve_entry {
};
struct flat_dt_property {
- uint32_t nameoff;
uint32_t len;
+ uint32_t nameoff;
char data[0];
};
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next reply other threads:[~2007-02-26 0:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-26 0:02 David Gibson [this message]
2007-02-27 14:48 ` [dtc] Fix flat_dt_property structure Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070226000224.GB29826@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=jdl@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox