linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Christian Krafft <krafft@de.ibm.com>
To: michael@ellerman.id.au
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
	"openipmi-developer@lists.sourceforge.net"
	<openipmi-developer@lists.sourceforge.net>,
	Arnd Bergmann <arnd.bergmann@de.ibm.com>
Subject: [patch] ipmi: check, if default ports are accessible on PPC
Date: Mon, 26 Feb 2007 16:09:17 +0100	[thread overview]
Message-ID: <20070226160917.2c801ec7@localhost> (raw)
In-Reply-To: <1172295412.16060.8.camel@concordia.ozlabs.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]

Subject: ipmi: check, if default ports are accessible on PPC

From: Christian Krafft <krafft@de.ibm.com>

ipmi_si_intf tries to access default ports, if no device could
be found elsewhere. On PPC we have a function to check,
if these legacy IO ports are accessible. This patch adds
a check for these ports on PPC.
This patch fixes a breakage of IPMI module
on PPC machines without a BMC.

Signed-off-by: Christian Krafft <krafft@de.ibm.com>

Index: linux/drivers/char/ipmi/ipmi_si_intf.c
===================================================================
--- linux.orig/drivers/char/ipmi/ipmi_si_intf.c
+++ linux/drivers/char/ipmi/ipmi_si_intf.c
@@ -2580,6 +2580,11 @@ static __devinit void default_find_bmc(v
 		if (!info)
 			return;
 
+#ifdef CONFIG_PPC_MERGE
+		if (check_legacy_ioport(ipmi_defaults[i].port))
+			continue;
+#endif
+
 		info->addr_source = NULL;
 
 		info->si_type = ipmi_defaults[i].type;
 

-- 
Mit freundlichen Gruessen,
kind regards,

Christian Krafft
IBM Systems & Technology Group,
Linux Kernel Development
IT Specialist


Vorsitzender des Aufsichtsrats:	Johann Weihen
Geschaeftsfuehrung:		Herbert Kircher
Sitz der Gesellschaft:		Boeblingen
Registriergericht:		Amtsgericht Stuttgart, HRB 243294


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

       reply	other threads:[~2007-02-26 15:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1172223703.4695.59.camel@concordia.ozlabs.ibm.com>
     [not found] ` <20070223135859.62e19ca8@localhost>
     [not found]   ` <1172295412.16060.8.camel@concordia.ozlabs.ibm.com>
2007-02-26 15:09     ` Christian Krafft [this message]
2007-02-27  2:27       ` [patch] ipmi: check, if default ports are accessible on PPC Michael Ellerman
2007-04-20 17:48       ` Olaf Hering
2007-04-20 18:08         ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070226160917.2c801ec7@localhost \
    --to=krafft@de.ibm.com \
    --cc=arnd.bergmann@de.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).