From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from one.firstfloor.org (one.firstfloor.org [213.235.205.2]) by ozlabs.org (Postfix) with ESMTP id 7F2FDDDF88 for ; Sun, 4 Mar 2007 00:02:20 +1100 (EST) Date: Sat, 3 Mar 2007 13:33:40 +0100 From: Andi Kleen To: Benjamin Herrenschmidt Subject: Re: [PATCH] ehea: Optional TX/RX path optimized for SMP Message-ID: <20070303123340.GB5357@one.firstfloor.org> References: <200702231730.58579.ossthema@de.ibm.com> <1172910508.8184.53.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1172910508.8184.53.camel@localhost.localdomain> Cc: Thomas Klein , Andi Kleen , Jan-Bernd Themann , netdev , linux-kernel , Christoph Raisch , linux-ppc , Marcus Eder , Stefan Roscher List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Mar 03, 2007 at 09:28:28AM +0100, Benjamin Herrenschmidt wrote: > On Sat, 2007-03-03 at 04:06 +0100, Andi Kleen wrote: > > Jan-Bernd Themann writes: > > > > > > Are there any concerns about this approach? > > > > Yes. You should fix the NAPI code instead of trying to work > > around it. > > NAPI is being fixed but the fix will take time to get in. In the > meantime, the solution to get something working is the workaround If it works right now with just a little less efficiency there is no pressing need to do workarounds until the real solution. Besides I doubt that patch would have made .21 anyways and in .22 you might already have multiqueue NAPI. -Andi