Re: [PATCH 14/15] Early serial debug support for PPC44x

[David Gibson <dwg@au1.ibm.com>]

On Fri, Mar 09, 2007 at 11:42:01AM -0600, Josh Boyer wrote:
> On Thu, 2007-03-08 at 13:44 -0600, Josh Boyer wrote:
> > On Mon, 2007-03-05 at 14:24 +1100, David Gibson wrote:
> > > 
> > > +config PPC_EARLY_DEBUG_44x_PHYSLOW
> > > +	hex
> > > +	depends PPC_EARLY_DEBUG_44x
> > > +	default "0x40000200"
> > > +
> > > +config PPC_EARLY_DEBUG_44x_PHYSHIGH
> > > +	hex
> > > +	depends PPC_EARLY_DEBUG_44x
> > > +	default "0x1"
> > > +
> > 
> > These two options need to have some kind of description string next to
> > hex otherwise Kconfig will not allow you to set them.  I noticed this
> > while playing with bamboo.  So something like:
> > 
> > config PPC_EARLY_DEBUG_44x_PHYSLOW
> > 	hex "The low 32bits of the UART address"
> > 
> > That will allow you to change the values from the default.
> 
> And here's a patch to do that.
> 
> Fix the PPC_EARLY_DEBUG_44x options to allow setting something other
> than the default.

Ta, I'll fold that in.  Incidentally the idea is that the default will
change depending on config.  So if only bamboo is configured, it
should just work.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson