linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Nathan Lynch <ntl@pobox.com>
To: Will Schmidt <will_schmidt@vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, sfr@canb.auug.org.au
Subject: Re: [PATCH 1/2] [powerpc] export symbols for use by lparcfg
Date: Mon, 12 Mar 2007 17:14:18 -0500	[thread overview]
Message-ID: <20070312221418.GG18478@localdomain> (raw)
In-Reply-To: <1173737143.7716.22.camel@localhost>

Will Schmidt wrote:
> On Mon, 2007-12-03 at 15:24 -0500, Nathan Lynch wrote:
> > Will Schmidt wrote:
> > > 
> > > +EXPORT_SYMBOL_GPL(vdso_data);
> > 
> > Hmm, I don't think lparcfg needs to access vdso_data at all.
> 
> It does via the reference here: 
> 
> 	partition_potential_processors = vdso_data->processorCount

I said lparcfg doesn't _need_ to access it :)

I was trying to show how the code could be changed to not use it:

> > 
> > In pseries_lparcfg_data we have:
> > 
> >         lrdrp = get_property(rtas_node, "ibm,lrdr-capacity", NULL);
> > 
> >         if (lrdrp == NULL) {
> >                 partition_potential_processors = vdso_data->processorCount;
> >         } else {
> >                 partition_potential_processors = *(lrdrp + 4);
> >         }
> > 
> >         partition_active_processors = lparcfg_count_active_processors();
> > 
> > But if there's no ibm,lrdr-capacity property then the system doesn't
> > support adding processors, so partition_potential_processors should be
> > equal to partition_active_processors.

Basically, calculate partition_active_processors first, then if !lrdrp,
partition_potential_processors = partition_active_processors.

  reply	other threads:[~2007-03-12 22:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-12 19:21 [PATCH 1/2] [powerpc] export symbols for use by lparcfg Will Schmidt
2007-03-12 19:21 ` [PATCH 2/2] [powerpc] replace if-then-else with a switch statement Will Schmidt
2007-03-12 20:24 ` [PATCH 1/2] [powerpc] export symbols for use by lparcfg Nathan Lynch
2007-03-12 22:05   ` Will Schmidt
2007-03-12 22:14     ` Nathan Lynch [this message]
2007-03-12 21:32 ` Christoph Hellwig
2007-03-12 22:07   ` Will Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070312221418.GG18478@localdomain \
    --to=ntl@pobox.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=sfr@canb.auug.org.au \
    --cc=will_schmidt@vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).