* [PATCH 04/19] bootwrapper: Rename ft_node_add() to ft_get_phandle().
@ 2007-03-12 20:41 Scott Wood
2007-03-12 22:32 ` Mark A. Greer
0 siblings, 1 reply; 3+ messages in thread
From: Scott Wood @ 2007-03-12 20:41 UTC (permalink / raw)
To: paulus; +Cc: linuxppc-dev
This name better reflects what the function does, which is to
look up the phandle for an internal node pointer, and add it to the
internal pointer to phandle table if not found.
Signed-off-by: Scott Wood <scottwood@freescale.com>
---
arch/powerpc/boot/flatdevtree.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/boot/flatdevtree.c b/arch/powerpc/boot/flatdevtree.c
index 02823a8..971420a 100644
--- a/arch/powerpc/boot/flatdevtree.c
+++ b/arch/powerpc/boot/flatdevtree.c
@@ -36,7 +36,7 @@ static char *ft_root_node(struct ft_cxt *cxt)
/* Routines for keeping node ptrs returned by ft_find_device current */
/* First entry not used b/c it would return 0 and be taken as NULL/error */
-static void *ft_node_add(struct ft_cxt *cxt, char *node)
+static void *ft_get_phandle(struct ft_cxt *cxt, char *node)
{
unsigned int i;
@@ -642,7 +642,7 @@ void *ft_find_device(struct ft_cxt *cxt, const char *srch_path)
if (srch_path[0] != '/')
return NULL;
node = ft_find_descendent(cxt, ft_root_node(cxt), srch_path);
- return ft_node_add(cxt, node);
+ return ft_get_phandle(cxt, node);
}
void *ft_find_descendent(struct ft_cxt *cxt, void *top, const char *srch_path)
--
1.5.0.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 04/19] bootwrapper: Rename ft_node_add() to ft_get_phandle().
2007-03-12 20:41 [PATCH 04/19] bootwrapper: Rename ft_node_add() to ft_get_phandle() Scott Wood
@ 2007-03-12 22:32 ` Mark A. Greer
2007-03-13 1:41 ` David Gibson
0 siblings, 1 reply; 3+ messages in thread
From: Mark A. Greer @ 2007-03-12 22:32 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev, paulus
On Mon, Mar 12, 2007 at 02:41:44PM -0600, Scott Wood wrote:
> This name better reflects what the function does, which is to
> look up the phandle for an internal node pointer, and add it to the
> internal pointer to phandle table if not found.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
Acked-by: Mark A. Greer <mgreer@mvista.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 04/19] bootwrapper: Rename ft_node_add() to ft_get_phandle().
2007-03-12 22:32 ` Mark A. Greer
@ 2007-03-13 1:41 ` David Gibson
0 siblings, 0 replies; 3+ messages in thread
From: David Gibson @ 2007-03-13 1:41 UTC (permalink / raw)
To: Mark A. Greer; +Cc: linuxppc-dev, paulus
On Mon, Mar 12, 2007 at 03:32:41PM -0700, Mark A. Greer wrote:
> On Mon, Mar 12, 2007 at 02:41:44PM -0600, Scott Wood wrote:
> > This name better reflects what the function does, which is to
> > look up the phandle for an internal node pointer, and add it to the
> > internal pointer to phandle table if not found.
> >
> > Signed-off-by: Scott Wood <scottwood@freescale.com>
>
> Acked-by: Mark A. Greer <mgreer@mvista.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-03-13 1:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-12 20:41 [PATCH 04/19] bootwrapper: Rename ft_node_add() to ft_get_phandle() Scott Wood
2007-03-12 22:32 ` Mark A. Greer
2007-03-13 1:41 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).