From: David Gibson <david@gibson.dropbear.id.au>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, Stefan Roese <sr@denx.de>
Subject: Re: [PATCH] ppc: Add support for bigger page sizes than 4KB on PPC44x
Date: Tue, 13 Mar 2007 16:10:31 +1100 [thread overview]
Message-ID: <20070313051031.GQ29506@localhost.localdomain> (raw)
In-Reply-To: <17910.12015.508991.966593@cargo.ozlabs.ibm.com>
On Tue, Mar 13, 2007 at 03:56:15PM +1100, Paul Mackerras wrote:
> Stefan Roese writes:
>
> > +config PPC_PAGE_SHIFT
> > + int "Page size (12=>4KB; 16=>64KB)"
> > + default "12"
> > + range 12 16
> > + help
> > + The PAGE_SIZE definition. Increasing the page size may
> > + improve the system performance in some dedicated cases.
> > +
> > + If unsure, set it to 12 (4KB).
>
> [snip]
>
> > +#else
> > +#error "Unsupported PAGE_SIZE"
> > +#endif
>
> If you only support 4k and 64k page sizes, why do you let the user
> choose 13, 14 or 15 for PPC_PAGE_SHIFT? Why not just have a "64k
> pages" boolean option like 64-bit powerpc does?
As far as I can tell from the patch, 14 should work too (16kB pages).
13 or 15 won't, since only power-of-4 pagesizes are supported on 44x.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-03-13 5:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 21:54 [PATCH] ppc: Add support for bigger page sizes than 4KB on PPC44x Stefan Roese
2007-03-13 4:56 ` Paul Mackerras
2007-03-13 5:10 ` David Gibson [this message]
2007-03-13 7:12 ` Benjamin Herrenschmidt
2007-03-13 7:37 ` Stefan Roese
2007-03-13 9:37 ` Wolfgang Denk
2007-03-13 13:54 ` Benjamin Herrenschmidt
2007-03-13 9:42 ` Christoph Hellwig
2007-03-13 9:54 ` David Gibson
2007-03-13 14:00 ` Grant Likely
2007-03-13 14:09 ` Josh Boyer
2007-03-16 5:14 ` Paul Mackerras
-- strict thread matches above, loose matches on Subject: below --
2007-03-16 13:34 Yuri Tikhonov
2007-03-16 22:34 ` Paul Mackerras
2007-03-17 11:41 ` Yuri Tikhonov
2007-03-21 10:43 ` Paul Mackerras
2007-03-21 11:23 ` Yuri Tikhonov
2007-04-25 17:37 ` Yuri Tikhonov
2007-03-16 13:35 Yuri Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070313051031.GQ29506@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).