From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 13 Mar 2007 17:22:40 +1100 From: David Gibson To: Jon Loeliger Subject: [dtc] Add support for flat device tree format version 17 Message-ID: <20070313062240.GA22737@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , libfdt defined a new version of the flattened device tree format, version 17. It is backwards compatible with version 16, just adding an extra header field giving the size of the blob's structure blob. This patch adds support to dtc allowing it to read and write version 17 blobs. It also makes version 17 the default output version for blobs. Signed-off-by: David Gibson Index: dtc/dtc.c =================================================================== --- dtc.orig/dtc.c 2007-03-13 16:37:01.000000000 +1100 +++ dtc/dtc.c 2007-03-13 16:37:17.000000000 +1100 @@ -113,7 +113,7 @@ int main(int argc, char *argv[]) int opt; FILE *inf = NULL; FILE *outf = NULL; - int outversion = 0x10; + int outversion = 0x11; int reservenum = 1; int boot_cpuid_phys = 0xfeedbeef; Index: dtc/flat_dt.h =================================================================== --- dtc.orig/flat_dt.h 2007-03-13 16:33:23.000000000 +1100 +++ dtc/flat_dt.h 2007-03-13 16:38:09.000000000 +1100 @@ -25,11 +25,15 @@ struct boot_param_header { booting on */ /* version 3 fields below */ uint32_t size_dt_strings; /* size of the strings block */ + + /* version 17 fields below */ + uint32_t size_dt_struct; /* size of the DT structure block */ }; #define BPH_V1_SIZE (7*sizeof(uint32_t)) #define BPH_V2_SIZE (BPH_V1_SIZE + sizeof(uint32_t)) #define BPH_V3_SIZE (BPH_V2_SIZE + sizeof(uint32_t)) +#define BPH_V17_SIZE (BPH_V3_SIZE + sizeof(uint32_t)) struct reserve_entry { uint64_t address; Index: dtc/flattree.c =================================================================== --- dtc.orig/flattree.c 2007-03-13 16:32:58.000000000 +1100 +++ dtc/flattree.c 2007-03-13 17:20:53.000000000 +1100 @@ -26,6 +26,7 @@ #define FTF_NAMEPROPS 0x4 #define FTF_BOOTCPUID 0x8 #define FTF_STRTABSIZE 0x10 +#define FTF_STRUCTSIZE 0x20 static struct version_info { int version; @@ -41,6 +42,8 @@ static struct version_info { FTF_FULLPATH|FTF_VARALIGN|FTF_NAMEPROPS|FTF_BOOTCPUID|FTF_STRTABSIZE}, {0x10, 0x10, BPH_V3_SIZE, FTF_BOOTCPUID|FTF_STRTABSIZE}, + {0x11, 0x10, BPH_V17_SIZE, + FTF_BOOTCPUID|FTF_STRTABSIZE|FTF_STRUCTSIZE}, }; struct emitter { @@ -328,6 +331,8 @@ static void make_bph(struct boot_param_h bph->boot_cpuid_phys = cpu_to_be32(boot_cpuid_phys); if (vi->flags & FTF_STRTABSIZE) bph->size_dt_strings = cpu_to_be32(strsize); + if (vi->flags & FTF_STRUCTSIZE) + bph->size_dt_struct = cpu_to_be32(dtsize); } void dt_to_blob(FILE *f, struct boot_info *bi, int version, @@ -742,7 +747,7 @@ static struct node *unflatten_tree(struc struct boot_info *dt_from_blob(FILE *f) { - u32 magic, totalsize, version, size_str; + u32 magic, totalsize, version, size_str, size_dt; u32 off_dt, off_str, off_mem_rsvmap; int rc; char *blob; @@ -841,6 +846,13 @@ struct boot_info *dt_from_blob(FILE *f) if (off_str+size_str > totalsize) die("String table extends past total size\n"); } + + if (version >= 17) { + size_dt = be32_to_cpu(bph->size_dt_struct); + fprintf(stderr, "\tsize_dt_struct:\t\t%d\n", size_dt); + if (off_dt+size_dt > totalsize) + die("Structure block extends past total size\n"); + } if (version < 0x10) { flags |= FTF_FULLPATH | FTF_NAMEPROPS | FTF_VARALIGN; -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson