Re: [PATCH] ppc: Add support for bigger page sizes than 4KB on PPC44x

[Stefan Roese <sr@denx.de>]

On Tuesday 13 March 2007 08:12, Benjamin Herrenschmidt wrote:
> While it's a good idea, there are a couple of issues with the patch:
>
>  - It's arch/ppc. We shouldn't do new major features on this codebase.
> You are welcome however in helping moving over 4xx to arch/powerpc :-)

Yes, sure. But the project this patch was developed for started quite a while 
ago when absolutely no 4xx support was available in arch/powerpc. I'm of 
course aware that we have to move to arch/powerpc in the near future and am 
willing to help here.

>  - You only adapted head_4xx.S but the config option is global to all of
> arch/ppc, thus changing it will probably break everything else. Make
> sure the option is done in such a way that it can't be changed or the
> kernel doesn't build if changed for a processor family where you haven't
> implemented the support

OK, will address this problem later.

>  - Have you tried other page sizes ? How hard would it be to support 16K
> and what kind of performance numbers do you get with 16K ? It's a better
> compromise for some applications as 64K causes significant bloat of the
> page cache (among other things).

No, we haven't tested other page sizes. We chose 64K because it is the stripe 
size of the RAID arrays.

Thanks.

Best regards,
Stefan