* [PATCH 07/19] bootwrapper: Modify *pp, not *p, in ft_shuffle().
@ 2007-03-12 20:41 Scott Wood
2007-03-13 21:58 ` Mark A. Greer
0 siblings, 1 reply; 3+ messages in thread
From: Scott Wood @ 2007-03-12 20:41 UTC (permalink / raw)
To: paulus; +Cc: linuxppc-dev
Move the caller's pointer back to match the change in the region's start,
rather than alter a byte of the device tree's content.
Signed-off-by: Scott Wood <scottwood@freescale.com>
---
arch/powerpc/boot/flatdevtree.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/boot/flatdevtree.c b/arch/powerpc/boot/flatdevtree.c
index 0fa4f98..f2a29ca 100644
--- a/arch/powerpc/boot/flatdevtree.c
+++ b/arch/powerpc/boot/flatdevtree.c
@@ -246,7 +246,7 @@ static int ft_shuffle(struct ft_cxt *cxt, char **pp, enum ft_rgn_id rgn,
if (rgn == FT_STRUCT)
ft_node_update_before(cxt, p, -nextra);
}
- *p -= nextra;
+ *pp -= nextra;
cxt->rgn[rgn].start -= nextra;
cxt->rgn[rgn].size += nextra;
return 1;
--
1.5.0.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 07/19] bootwrapper: Modify *pp, not *p, in ft_shuffle().
2007-03-12 20:41 [PATCH 07/19] bootwrapper: Modify *pp, not *p, in ft_shuffle() Scott Wood
@ 2007-03-13 21:58 ` Mark A. Greer
2007-03-13 23:31 ` David Gibson
0 siblings, 1 reply; 3+ messages in thread
From: Mark A. Greer @ 2007-03-13 21:58 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev, paulus
On Mon, Mar 12, 2007 at 02:41:48PM -0600, Scott Wood wrote:
> Move the caller's pointer back to match the change in the region's start,
> rather than alter a byte of the device tree's content.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
Acked-by: Mark A. Greer <mgreer@mvista.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 07/19] bootwrapper: Modify *pp, not *p, in ft_shuffle().
2007-03-13 21:58 ` Mark A. Greer
@ 2007-03-13 23:31 ` David Gibson
0 siblings, 0 replies; 3+ messages in thread
From: David Gibson @ 2007-03-13 23:31 UTC (permalink / raw)
To: Mark A. Greer; +Cc: linuxppc-dev, paulus
On Tue, Mar 13, 2007 at 02:58:31PM -0700, Mark A. Greer wrote:
> On Mon, Mar 12, 2007 at 02:41:48PM -0600, Scott Wood wrote:
> > Move the caller's pointer back to match the change in the region's start,
> > rather than alter a byte of the device tree's content.
> >
> > Signed-off-by: Scott Wood <scottwood@freescale.com>
>
> Acked-by: Mark A. Greer <mgreer@mvista.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-03-13 23:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-12 20:41 [PATCH 07/19] bootwrapper: Modify *pp, not *p, in ft_shuffle() Scott Wood
2007-03-13 21:58 ` Mark A. Greer
2007-03-13 23:31 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).