From: Al Viro <viro@ftp.linux.org.uk>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: linuxppc-dev@ozlabs.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/13] fix ps3fb glue allowing a modular build
Date: Wed, 14 Mar 2007 16:02:58 +0000 [thread overview]
Message-ID: <20070314160258.GK4095@ftp.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.62.0703141040030.28462@pademelon.sonytel.be>
On Wed, Mar 14, 2007 at 10:50:16AM +0100, Geert Uytterhoeven wrote:
> On Wed, 14 Mar 2007, Al Viro wrote:
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> NAK
>
> There are several problems with making it modular. I did try, cfr. the
> incomplete patchlets below.
[snip]
> And finally, make sure CONFIG_LOGO=n, as there's a bug in the logo code: logos
> are __initdata but the logo code still tries to draw them for a modular fbdev.
> Originally (eons ago) this case was handled by the flag initmem_freed, which no
> longer exists.
Lovely... Consider that one withdrawn, please. FWIW, if we leave it bool
(and flip_ctl mess alone would make a good reason for that) we probably want
to have it depend on FB=y
next prev parent reply other threads:[~2007-03-14 16:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 9:17 [PATCH 13/13] fix ps3fb glue allowing a modular build Al Viro
2007-03-14 9:50 ` Geert Uytterhoeven
2007-03-14 16:02 ` Al Viro [this message]
2007-03-14 16:17 ` Geert Uytterhoeven
2007-03-14 17:07 ` Al Viro
2007-03-14 17:23 ` Geert Uytterhoeven
2007-03-14 17:30 ` Linus Torvalds
2007-03-14 17:45 ` Geert Uytterhoeven
2007-03-14 17:59 ` Al Viro
2007-03-14 18:09 ` Geert Uytterhoeven
2007-03-14 18:25 ` Al Viro
2007-03-15 1:17 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070314160258.GK4095@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).