From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [195.92.253.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 02C73DDEF5 for ; Thu, 15 Mar 2007 03:03:07 +1100 (EST) Date: Wed, 14 Mar 2007 16:02:58 +0000 From: Al Viro To: Geert Uytterhoeven Subject: Re: [PATCH 13/13] fix ps3fb glue allowing a modular build Message-ID: <20070314160258.GK4095@ftp.linux.org.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: linuxppc-dev@ozlabs.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Mar 14, 2007 at 10:50:16AM +0100, Geert Uytterhoeven wrote: > On Wed, 14 Mar 2007, Al Viro wrote: > > Signed-off-by: Al Viro > > NAK > > There are several problems with making it modular. I did try, cfr. the > incomplete patchlets below. [snip] > And finally, make sure CONFIG_LOGO=n, as there's a bug in the logo code: logos > are __initdata but the logo code still tries to draw them for a modular fbdev. > Originally (eons ago) this case was handled by the flag initmem_freed, which no > longer exists. Lovely... Consider that one withdrawn, please. FWIW, if we leave it bool (and flip_ctl mess alone would make a good reason for that) we probably want to have it depend on FB=y