From: Al Viro <viro@ftp.linux.org.uk>
To: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
Cc: linuxppc-dev@ozlabs.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/13] BLK_DEV_IDE_CELLEB dependency fix
Date: Thu, 15 Mar 2007 05:36:07 +0000 [thread overview]
Message-ID: <20070315053607.GQ4095@ftp.linux.org.uk> (raw)
In-Reply-To: <200703150523.l2F5NelE001987@toshiba.co.jp>
On Thu, Mar 15, 2007 at 02:25:40PM +0900, Akira Iguchi wrote:
> Al wrote:
> >
> >It's bool and it depends on IDE => should depend on IDE=y
> >
> >Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> Move to "if BLK_DEV_IDEDMA_PCI" block because it depends on
> BLK_DEV_IDEDMA_PCI.
> +config BLK_DEV_IDE_CELLEB
> + bool "Toshiba's Cell Reference Set IDE support"
> + depends on PPC_CELLEB
> + help
> + This driver provides support for the built-in IDE controller on
> + Toshiba Cell Reference Board.
> + If unsure, say Y.
> +
Eh... You still need dependency on IDE=y; otherwise you'll get configs
with IDE=m, BLK_DEV_IDE_CELLEB=y and those won't link. BLK_DEV_IDEDMA_PCI
is selectable just fine with IDE=m.
It's the same problem as with ps3 fb.
next prev parent reply other threads:[~2007-03-15 5:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 9:16 [PATCH 10/13] BLK_DEV_IDE_CELLEB dependency fix Al Viro
2007-03-15 5:25 ` Akira Iguchi
[not found] ` <200703150523.l2F5NelE001987@toshiba.co.jp>
2007-03-15 5:36 ` Al Viro [this message]
2007-03-15 6:10 ` Akira Iguchi
[not found] ` <200703150608.l2F68JY2026403@toshiba.co.jp>
2007-03-15 8:46 ` Al Viro
2007-03-15 19:48 ` Bartlomiej Zolnierkiewicz
2007-03-16 1:32 ` Akira Iguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070315053607.GQ4095@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akira2.iguchi@toshiba.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).