linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <hansendc@us.ibm.com>
To: boutcher@us.ibm.com
Cc: linuxppc-dev@ozlabs.org, ryanarn@us.ibm.com,
	Dave Hansen <hansendc@us.ibm.com>,
	devilbis@us.ibm.com, sfr@au1.ibm.com
Subject: [PATCH] fix viocons allyesconfig #error
Date: Fri, 16 Mar 2007 09:42:09 -0700	[thread overview]
Message-ID: <20070316164209.935CC8F0@elm3b173.beaverton.ibm.com> (raw)


make allyesconfig bombs out, and probably has for years.

This should fix it in the right way.  The #error in a .c
file is a wee bit of a hack, and Kconfig should be a bit
more refined.

Signed-off-by: Dave Hansen <hansendc@us.ibm.com>
---


diff -puN arch/powerpc/platforms/iseries/Kconfig~viocons-allyesconfig-fix arch/powerpc/platforms/iseries/Kconfig
--- lxc/arch/powerpc/platforms/iseries/Kconfig~viocons-allyesconfig-fix	2007-03-15 08:52:51.000000000 -0700
+++ lxc-dave/arch/powerpc/platforms/iseries/Kconfig	2007-03-15 08:52:51.000000000 -0700
@@ -4,11 +4,15 @@ menu "iSeries device drivers"
 
 config VIOCONS
 	tristate "iSeries Virtual Console Support (Obsolete)"
+	depends on !VT
 	help
 	  This is the old virtual console driver for legacy iSeries.
 	  You should use the iSeries Hypervisor Virtual Console
 	  support instead.
 
+comment "iSeries Virtual Console Support requires disabling VT"
+	depends on VT
+
 config VIODASD
 	tristate "iSeries Virtual I/O disk support"
 	help
diff -puN drivers/char/viocons.c~viocons-allyesconfig-fix drivers/char/viocons.c
--- lxc/drivers/char/viocons.c~viocons-allyesconfig-fix	2007-03-15 08:52:51.000000000 -0700
+++ lxc-dave/drivers/char/viocons.c	2007-03-15 08:52:51.000000000 -0700
@@ -49,10 +49,6 @@
 #include <asm/iseries/hv_lp_config.h>
 #include <asm/iseries/hv_call.h>
 
-#ifdef CONFIG_VT
-#error You must turn off CONFIG_VT to use CONFIG_VIOCONS
-#endif
-
 #define VIOTTY_MAGIC (0x0DCB)
 #define VTTY_PORTS 10
 
_

                 reply	other threads:[~2007-03-16 16:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070316164209.935CC8F0@elm3b173.beaverton.ibm.com \
    --to=hansendc@us.ibm.com \
    --cc=boutcher@us.ibm.com \
    --cc=devilbis@us.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=ryanarn@us.ibm.com \
    --cc=sfr@au1.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).