From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 20 Mar 2007 11:38:47 +1100 From: David Gibson To: Milton Miller Subject: Re: [PATCH 4/7] bootwrapper: add a fatal error helper Message-ID: <20070320003847.GB19728@localhost.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: linuxppc-dev@ozlabs.org, Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Mar 19, 2007 at 02:58:03PM -0600, Milton Miller wrote: > Add a macro fatal that calls printf then exit. User must include stdio.h. > > Typically replaces 3 lines with 1, although I added back some whitespace. > > Signed-off-by: Milton Miller One tiny nit... [snip] > Index: kernel/arch/powerpc/boot/ops.h > =================================================================== > --- kernel.orig/arch/powerpc/boot/ops.h 2007-03-19 08:32:50.000000000 -0500 > +++ kernel/arch/powerpc/boot/ops.h 2007-03-19 08:33:02.000000000 -0500 > @@ -157,6 +157,8 @@ static inline void exit(void) > platform_ops.exit(); > for(;;); > } > +#define fatal(args...) { printf(args); exit(); } > + This is the old gcc way of doing a varargs macro, not the new C99 way. The new way would be: #define fata(...) { printf(__VA_ARGS__); exit(); } -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson