From: Wolfgang Denk <wd@denx.de>
To: Valentine Barshak <vbarshak@ru.mvista.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] PPC440EPx/440GRx Sequoia/Rainier board support.
Date: Wed, 21 Mar 2007 16:43:17 +0100 [thread overview]
Message-ID: <20070321154317.924703535D3@atlas.denx.de> (raw)
In-Reply-To: Your message of "Wed, 21 Mar 2007 17:50:06 +0300." <4601461E.9010006@ru.mvista.com>
Valentine,
in message <4601461E.9010006@ru.mvista.com> you wrote:
>
> Add AMCC PPC440EPx/440GRx Sequoia/Rainier board support.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
Umm...
> --- linux.orig/arch/ppc/platforms/4xx/ppc440epx.c 1970-01-01 03:00:00.000000000 +0300
> +++ linux/arch/ppc/platforms/4xx/ppc440epx.c 2007-03-20 14:43:37.000000000 +0300
> @@ -0,0 +1,284 @@
> +/*
> + * arch/ppc/platforms/4xx/ppc440epx.c
> + *
> + * PPC440EPx I/O descriptions
> + *
> + * Wade Farnsworth <wfarnsworth@mvista.com>
> + * Copyright 2004-2007 MontaVista Software Inc.
> + * Copyright 2006 AMCC
The same file in our repository looks like this:
/*
* arch/ppc/platforms/4xx/ppc440epx.c
*
* PPC440EPx I/O descriptions
*
* Copyright 2007 DENX Software Engineering, Stefan Roese <sr@denx.de>
*
* Wade Farnsworth <wfarnsworth@mvista.com>
* Copyright 2004 MontaVista Software Inc.
* Copyright 2006 AMCC
In other words: You *removed* Stefan Roese's (resp. DENX) Copyright
entry, and replaced it by one for MV?
I think this was not done by accident.
I don't know what to say.
I think your patches should be rejected.
Wolfgang Denk
--
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"If you own a machine, you are in turn owned by it, and spend your
time serving it..." - Marion Zimmer Bradley, _The Forbidden Tower_
next prev parent reply other threads:[~2007-03-21 15:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 19:24 [PATCH] PPC440EPx/440GRx Sequoia/Rainier board support Valentine Barshak
2007-03-21 13:26 ` Stefan Roese
2007-03-21 13:39 ` Josh Boyer
2007-03-21 14:50 ` Valentine Barshak
2007-03-21 15:43 ` Wolfgang Denk [this message]
2007-03-21 16:06 ` Stefan Roese
2007-03-21 16:19 ` Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321154317.924703535D3@atlas.denx.de \
--to=wd@denx.de \
--cc=linuxppc-embedded@ozlabs.org \
--cc=vbarshak@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).