From: olof@lixom.net (Olof Johansson)
To: Valentine Barshak <vbarshak@ru.mvista.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] PPC440EPx/440GRx EMAC support.
Date: Wed, 21 Mar 2007 11:04:38 -0500 [thread overview]
Message-ID: <20070321160438.GA3023@lixom.net> (raw)
In-Reply-To: <46003608.70308@ru.mvista.com>
On Tue, Mar 20, 2007 at 10:29:12PM +0300, Valentine Barshak wrote:
> diff -ruN linux.orig/drivers/net/ibm_emac/ibm_emac_core.c linux/drivers/net/ibm_emac/ibm_emac_core.c
> --- linux.orig/drivers/net/ibm_emac/ibm_emac_core.c 2007-03-16 18:03:51.000000000 +0300
> +++ linux/drivers/net/ibm_emac/ibm_emac_core.c 2007-03-18 18:53:08.000000000 +0300
> @@ -86,7 +86,8 @@
> static u32 busy_phy_map;
>
> #if defined(CONFIG_IBM_EMAC_PHY_RX_CLK_FIX) && \
> - (defined(CONFIG_405EP) || defined(CONFIG_440EP) || defined(CONFIG_440GR))
> + (defined(CONFIG_405EP) || defined(CONFIG_440EP) || defined(CONFIG_440GR) || \
> + defined(CONFIG_440EPX) || defined(CONFIG_440GRX))
This is getting out of control. Please add a config option for this,
and add "select" statements to the Kconfig file where any of the above
CONFIG_4.* are defined.
> /* 405EP has "EMAC to PHY Control Register" (CPC0_EPCTL) which can help us
> * with PHY RX clock problem.
> * 440EP/440GR has more sane SDR0_MFR register implementation than 440GX, which
> diff -ruN linux.orig/drivers/net/ibm_emac/ibm_emac.h linux/drivers/net/ibm_emac/ibm_emac.h
> --- linux.orig/drivers/net/ibm_emac/ibm_emac.h 2007-03-16 18:03:51.000000000 +0300
> +++ linux/drivers/net/ibm_emac/ibm_emac.h 2007-03-18 18:53:08.000000000 +0300
> @@ -26,7 +26,7 @@
> #if !defined(CONFIG_405GP) && !defined(CONFIG_405GPR) && !defined(CONFIG_405EP) && \
> !defined(CONFIG_440GP) && !defined(CONFIG_440GX) && !defined(CONFIG_440SP) && \
> !defined(CONFIG_440EP) && !defined(CONFIG_NP405H) && !defined(CONFIG_440SPE) && \
> - !defined(CONFIG_440GR)
> + !defined(CONFIG_440GR) && !defined(CONFIG_440EPX) && !defined(CONFIG_440GRX)
Same here. I know you only added a couple more, but it's reached critical
mass (well, it did a while ago).
-Olof
next prev parent reply other threads:[~2007-03-21 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 19:29 [PATCH] PPC440EPx/440GRx EMAC support Valentine Barshak
2007-03-20 19:36 ` Sergei Shtylyov
2007-03-21 16:04 ` Olof Johansson [this message]
2007-03-21 16:22 ` Eugene Surovegin
2007-03-21 18:13 ` Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321160438.GA3023@lixom.net \
--to=olof@lixom.net \
--cc=linuxppc-embedded@ozlabs.org \
--cc=vbarshak@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).