From: Eugene Surovegin <ebs@ebshome.net>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] PPC440EPx/440GRx EMAC support.
Date: Wed, 21 Mar 2007 09:22:07 -0700 [thread overview]
Message-ID: <20070321162207.GA2583@gate.ebshome.net> (raw)
In-Reply-To: <20070321160438.GA3023@lixom.net>
On Wed, Mar 21, 2007 at 11:04:38AM -0500, Olof Johansson wrote:
> On Tue, Mar 20, 2007 at 10:29:12PM +0300, Valentine Barshak wrote:
> > diff -ruN linux.orig/drivers/net/ibm_emac/ibm_emac.h linux/drivers/net/ibm_emac/ibm_emac.h
> > --- linux.orig/drivers/net/ibm_emac/ibm_emac.h 2007-03-16 18:03:51.000000000 +0300
> > +++ linux/drivers/net/ibm_emac/ibm_emac.h 2007-03-18 18:53:08.000000000 +0300
> > @@ -26,7 +26,7 @@
> > #if !defined(CONFIG_405GP) && !defined(CONFIG_405GPR) && !defined(CONFIG_405EP) && \
> > !defined(CONFIG_440GP) && !defined(CONFIG_440GX) && !defined(CONFIG_440SP) && \
> > !defined(CONFIG_440EP) && !defined(CONFIG_NP405H) && !defined(CONFIG_440SPE) && \
> > - !defined(CONFIG_440GR)
> > + !defined(CONFIG_440GR) && !defined(CONFIG_440EPX) && !defined(CONFIG_440GRX)
>
> Same here. I know you only added a couple more, but it's reached critical
> mass (well, it did a while ago).
No, it's not same here. Please, take a time and look at the full code
this particular snippet has nothing to do with Konfig stuff.
One can argue that it can be removed altogether, but I added this ugly
check for a reason - people were adding support for new 4xx SoCs
blindly in the past without checking that EMAC registers weren't
changed slightly.
So, Valentine, keep this particular ugly ifdef as it is.
Also, Valentine, next time CC me with any EMAC changes because I'm not
actively reading PPC maillists these days.
--
Eugene
next prev parent reply other threads:[~2007-03-21 16:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 19:29 [PATCH] PPC440EPx/440GRx EMAC support Valentine Barshak
2007-03-20 19:36 ` Sergei Shtylyov
2007-03-21 16:04 ` Olof Johansson
2007-03-21 16:22 ` Eugene Surovegin [this message]
2007-03-21 18:13 ` Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070321162207.GA2583@gate.ebshome.net \
--to=ebs@ebshome.net \
--cc=linuxppc-embedded@ozlabs.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).