From: David Gibson <david@gibson.dropbear.id.au>
To: Milton Miller <miltonm@bga.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/4] powerpc: Add device tree utility functions to zImage
Date: Thu, 22 Mar 2007 14:02:58 +1100 [thread overview]
Message-ID: <20070322030258.GJ2295@localhost.localdomain> (raw)
In-Reply-To: <200703211030.l2LAU2TE099295@sullivan.realtime.net>
On Wed, Mar 21, 2007 at 09:03:02AM -0600, Milton Miller wrote:
>
> Following your reply to Scott's comments about space in the xlate_reg
> thread, how about splitting the ones used in main.c which will always
> be included from the others that are more for device tree pokers.
Yeah, I guess.
> For that matter, your streamlining adds runtime overhead. Why not
> cache the checked or created phandle?
Well, I made a judgeement that source simplicity was more valuable
than runtime speed. However, in the second spin, I've reconsidered
and gotten rid of the dt_path_{get,set}prop functions entirely which
addresses both concerns above.
> Also, in dt_path_getprop, did you want to call finddevice instead of
> testing the function is not weak and undefined?
Yes. Fixed now.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-03-22 3:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-21 6:30 [0/4] Further zImage work David Gibson
2007-03-21 6:31 ` [PATCH 2/4] powerpc: Add device tree utility functions to zImage David Gibson
2007-03-21 15:03 ` Milton Miller
2007-03-22 3:02 ` David Gibson [this message]
2007-03-21 17:10 ` Segher Boessenkool
2007-03-21 23:31 ` David Gibson
2007-03-21 21:57 ` Scott Wood
2007-03-22 1:36 ` David Gibson
2007-03-21 6:31 ` [PATCH 1/4] powerpc: Add gcc format warnings to zImage printf() David Gibson
2007-03-21 15:03 ` Milton Miller
2007-03-22 1:35 ` David Gibson
2007-03-21 6:31 ` [PATCH 4/4] powerpc: New reg.h for the zImage David Gibson
2007-03-21 6:31 ` [PATCH 3/4] powerpc: Clean up zImage handling of the command line David Gibson
2007-03-22 5:48 ` [0/4] Further zImage work (spin 2) David Gibson
2007-03-22 5:59 ` [PATCH 1/4] powerpc: Add gcc format warnings to zImage printf() David Gibson
2007-03-22 6:02 ` [PATCH 4/4] powerpc: New reg.h for the zImage David Gibson
2007-03-22 6:02 ` [PATCH 3/4] powerpc: Clean up zImage handling of the command line David Gibson
2007-03-22 6:02 ` [PATCH 2/4] powerpc: Add device tree utility functions to zImage David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070322030258.GJ2295@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).