From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olof@lixom.net>
Received: from mail.lixom.net (lixom.net [66.141.50.11])
	by ozlabs.org (Postfix) with ESMTP id 046C5DDFEA
	for <linuxppc-dev@ozlabs.org>; Fri, 23 Mar 2007 04:39:05 +1100 (EST)
Date: Thu, 22 Mar 2007 12:53:24 -0500
To: Jake Moilanen <moilanen@austin.ibm.com>
Subject: Re: [PATCH] DMA 4GB boundary protection
Message-ID: <20070322175324.GA21120@lixom.net>
References: <1172872183.5310.145.camel@goblue>
	<20070303232915.GB8028@lixom.net>
	<1174511149.5225.135.camel@goblue>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <1174511149.5225.135.camel@goblue>
From: olof@lixom.net (Olof Johansson)
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

On Wed, Mar 21, 2007 at 04:05:48PM -0500, Jake Moilanen wrote:

> @@ -480,6 +495,21 @@ struct iommu_table *iommu_init_table(str
>  	ppc_md.tce_free(tbl, tbl->it_offset, tbl->it_size);
>  #endif
>  
> +	/*
> +	 * DMA cannot cross 4 GB boundary.  Mark first entry of each 4
> +	 * GB chunk as reserved.
> +	 */
> +	if (protect4gb) {
> +		start_addr = tbl->it_offset << IOMMU_PAGE_SHIFT;
> +		/* go up to next 4GB boundary */
> +		start_addr = (start_addr + 0x00000000ffffffffl) >> 32;
> +		end_addr = (tbl->it_offset + tbl->it_size) << IOMMU_PAGE_SHIFT;
> +		for (index = start_addr; index < end_addr; index += (1l << 32)) {
> +			/* Reserve 4GB entry */
> +			__set_bit((index >> IOMMU_PAGE_SHIFT) - tbl->it_offset,
> tbl->it_map);
> +		}
> +	}
> +


This is done a bit more complicated than it has to be. The >> 32 is a
red flag as well.

I would also like it to be the last page in the range, not the first
(since otherwise you'll reserve even if the window is less than 4GB.

Something like (untested):

	entries_per_4g = 0x100000000 >> IOMMU_PAGE_SHIFT;

	/* Mark the last bit before a 4GB boundary as used */
	start_index = tbl->it_offset | (entries_per_4g - 1);
	end_index = tbl->it_offset + tbl->it_size;

	for (index = start_index; index < end_index; index += entries_per_4g)
		__set_bit(index, tbl->it_map);

Is easier to follow.


-Olof