From: David Gibson <david@gibson.dropbear.id.au>
To: Domen Puncer <domen.puncer@telargo.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 4/10] Add arch/powerpc driver for UIC, PPC4xx interrupt controller
Date: Fri, 23 Mar 2007 14:28:58 +1100 [thread overview]
Message-ID: <20070323032858.GF28006@localhost.localdomain> (raw)
In-Reply-To: <20070322095118.GA18236@moe.telargo.com>
On Thu, Mar 22, 2007 at 10:51:18AM +0100, Domen Puncer wrote:
> On 22/03/07 20:22 +1100, David Gibson wrote:
> > +static int uic_set_irq_type(unsigned int virq, unsigned int flow_type)
>
> > + case IRQ_TYPE_LEVEL_HIGH:
> > + trigger = 0; polarity = 1;
> > + break;
> > + case IRQ_TYPE_LEVEL_LOW:
> > + trigger = 0; polarity = 1;
>
> Is this intended to be the same?
Oops, no. Thanks for spotting that, the Ebony has no level-low
devices, so I didn't notice any problems.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-03-23 3:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 6:06 [0/10] arch/powerpc Ebony support (draft 3) David Gibson
2007-03-22 6:10 ` [PATCH 1/10] Define FIXED_PORT flag for serial_core David Gibson
2007-03-22 9:22 ` [PATCH 7/10] Early serial debug support for PPC44x David Gibson
2007-03-22 9:22 ` [PATCH 5/10] Port 44x MMU definitions to ARCH=powerpc David Gibson
2007-03-23 14:09 ` Kumar Gala
2007-03-23 23:30 ` David Gibson
2007-03-22 9:22 ` [PATCH 4/10] Add arch/powerpc driver for UIC, PPC4xx interrupt controller David Gibson
2007-03-22 9:51 ` Domen Puncer
2007-03-23 3:28 ` David Gibson [this message]
2007-03-23 12:20 ` Josh Boyer
2007-03-22 9:22 ` [PATCH 6/10] Support for Ebony in arch/powerpc David Gibson
2007-03-22 9:22 ` [PATCH 3/10] Re-organize Kconfig code for 4xx " David Gibson
2007-03-22 9:22 ` [PATCH 2/10] Use resource_size_t for serial port IO addresses David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070323032858.GF28006@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=domen.puncer@telargo.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).