From: Akinobu Mita <mita@fixstars.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>,
cbe-oss-dev@ozlabs.org, Arnd Bergmann <arnd@arndb.de>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: [PATCH] force -mno-string option on cell
Date: Fri, 23 Mar 2007 21:06:19 +0900 [thread overview]
Message-ID: <20070323120619.GA7472@localhost.localdomain> (raw)
In-Reply-To: <94d8e19d4b061504fcfd08d1ab70cc78@kernel.crashing.org>
GCC may generate inline copy loop to handle memcpy() function
instead of kernel defined memcpy() with -mstring or -Os.
But this inlined version of memcpy() caused an alignment interrupt
when copying from SPU local store on PS3.
(http://ozlabs.org/pipermail/cbe-oss-dev/2007-March/001348.html)
This patch deletes -mstring option on all powerpc and force -mno-string
option on Cell.
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Akinobu Mita <mita@fixstars.com>
---
arch/powerpc/Makefile | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Index: 2.6-git-ps3/arch/powerpc/Makefile
===================================================================
--- 2.6-git-ps3.orig/arch/powerpc/Makefile
+++ 2.6-git-ps3/arch/powerpc/Makefile
@@ -102,8 +102,9 @@ CFLAGS += $(call cc-option,-mno-altivec)
# kernel considerably.
CFLAGS += $(call cc-option,-funit-at-a-time)
-ifndef CONFIG_FSL_BOOKE
-CFLAGS += -mstring
+# No string instruction for SPE local store areas
+ifeq ($(CONFIG_PPC_CELL),y)
+CFLAGS += -mno-string
endif
ifeq ($(CONFIG_6xx),y)
next prev parent reply other threads:[~2007-03-23 12:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-22 6:23 [PATCH] powerpc: Always use -mno-string Benjamin Herrenschmidt
2007-03-22 12:06 ` Segher Boessenkool
2007-03-23 12:06 ` Akinobu Mita [this message]
2007-03-23 12:56 ` [PATCH] force -mno-string option on cell Segher Boessenkool
2007-03-23 19:38 ` Benjamin Herrenschmidt
2007-03-24 0:02 ` Segher Boessenkool
2007-03-23 20:46 ` [Cbe-oss-dev] " Arnd Bergmann
2007-03-26 12:00 ` Segher Boessenkool
2007-03-24 3:02 ` Paul Mackerras
2007-03-24 14:46 ` Segher Boessenkool
2007-03-23 13:37 ` Kumar Gala
2007-03-23 16:35 ` Segher Boessenkool
2007-03-23 19:46 ` Benjamin Herrenschmidt
2007-03-24 0:04 ` Segher Boessenkool
2007-03-26 8:54 ` Geert Uytterhoeven
2007-03-26 12:33 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070323120619.GA7472@localhost.localdomain \
--to=mita@fixstars.com \
--cc=arnd@arndb.de \
--cc=cbe-oss-dev@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).