* [patch 1/3] powerpc: delete -mstring option
@ 2007-04-10 11:13 Akinobu Mita
2007-04-10 12:47 ` Segher Boessenkool
0 siblings, 1 reply; 4+ messages in thread
From: Akinobu Mita @ 2007-04-10 11:13 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Arnd Bergmann, Paul Mackerras, cbe-oss-dev
There is no reason to force -mstring option.
(Kumar, please see patch 2/3 for FSL_BOOKE temporary fix)
Signed-off-by: Akinobu Mita <mita@fixstars.com>
Index: 2.6-git-ps3/arch/powerpc/Makefile
===================================================================
--- 2.6-git-ps3.orig/arch/powerpc/Makefile
+++ 2.6-git-ps3/arch/powerpc/Makefile
@@ -102,10 +102,6 @@ CFLAGS += $(call cc-option,-mno-altivec)
# kernel considerably.
CFLAGS += $(call cc-option,-funit-at-a-time)
-ifndef CONFIG_FSL_BOOKE
-CFLAGS += -mstring
-endif
-
ifeq ($(CONFIG_6xx),y)
CFLAGS += -mcpu=powerpc
endif
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 1/3] powerpc: delete -mstring option
2007-04-10 11:13 [patch 1/3] powerpc: delete -mstring option Akinobu Mita
@ 2007-04-10 12:47 ` Segher Boessenkool
2007-04-10 18:42 ` Kumar Gala
0 siblings, 1 reply; 4+ messages in thread
From: Segher Boessenkool @ 2007-04-10 12:47 UTC (permalink / raw)
To: Akinobu Mita; +Cc: Arnd Bergmann, linuxppc-dev, Paul Mackerras, cbe-oss-dev
> There is no reason to force -mstring option.
> (Kumar, please see patch 2/3 for FSL_BOOKE temporary fix)
> -ifndef CONFIG_FSL_BOOKE
> -CFLAGS += -mstring
> -endif
[and from 2/3]
> +ifeq ($(CONFIG_FSL_BOOKE),y)
> +CFLAGS += -mno-string
> +endif
This is the right solution, thank you for the patch.
But please fold these two together so that you're not
introducing a regression halfway the patch series.
Segher
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 1/3] powerpc: delete -mstring option
2007-04-10 12:47 ` Segher Boessenkool
@ 2007-04-10 18:42 ` Kumar Gala
2007-04-11 2:35 ` Akinobu Mita
0 siblings, 1 reply; 4+ messages in thread
From: Kumar Gala @ 2007-04-10 18:42 UTC (permalink / raw)
To: Segher Boessenkool
Cc: Arnd Bergmann, Akinobu Mita, linuxppc-dev, Paul Mackerras,
cbe-oss-dev
On Apr 10, 2007, at 7:47 AM, Segher Boessenkool wrote:
>> There is no reason to force -mstring option.
>> (Kumar, please see patch 2/3 for FSL_BOOKE temporary fix)
>
>> -ifndef CONFIG_FSL_BOOKE
>> -CFLAGS += -mstring
>> -endif
>
> [and from 2/3]
>
>> +ifeq ($(CONFIG_FSL_BOOKE),y)
>> +CFLAGS += -mno-string
>> +endif
>
> This is the right solution, thank you for the patch.
> But please fold these two together so that you're not
> introducing a regression halfway the patch series.
I agree this looks good and merge patches 1/3 and 2/3 into a single
patch.
- k
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 1/3] powerpc: delete -mstring option
2007-04-10 18:42 ` Kumar Gala
@ 2007-04-11 2:35 ` Akinobu Mita
0 siblings, 0 replies; 4+ messages in thread
From: Akinobu Mita @ 2007-04-11 2:35 UTC (permalink / raw)
To: Kumar Gala; +Cc: Arnd Bergmann, linuxppc-dev, Paul Mackerras, cbe-oss-dev
On Tue, Apr 10, 2007 at 01:42:15PM -0500, Kumar Gala wrote:
> >This is the right solution, thank you for the patch.
> >But please fold these two together so that you're not
> >introducing a regression halfway the patch series.
>
> I agree this looks good and merge patches 1/3 and 2/3 into a single
> patch.
Thansk, this is updated patch.
From: Akinobu Mita <mita@fixstars.com>
Subject: powerpc: delete -mstring option
There is no reason to force -mstring option.
This patch removes -mstring option, and adds -mno-string option
for FLS_BOOKE (Because GCC is now putting string instructions
even if you don't specify -mstring).
Signed-off-by: Akinobu Mita <mita@fixstars.com>
---
arch/powerpc/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: 2.6-git-ps3/arch/powerpc/Makefile
===================================================================
--- 2.6-git-ps3.orig/arch/powerpc/Makefile
+++ 2.6-git-ps3/arch/powerpc/Makefile
@@ -102,8 +102,8 @@ CFLAGS += $(call cc-option,-mno-altivec)
# kernel considerably.
CFLAGS += $(call cc-option,-funit-at-a-time)
-ifndef CONFIG_FSL_BOOKE
-CFLAGS += -mstring
+ifeq ($(CONFIG_FSL_BOOKE),y)
+CFLAGS += -mno-string
endif
ifeq ($(CONFIG_6xx),y)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-04-11 2:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-10 11:13 [patch 1/3] powerpc: delete -mstring option Akinobu Mita
2007-04-10 12:47 ` Segher Boessenkool
2007-04-10 18:42 ` Kumar Gala
2007-04-11 2:35 ` Akinobu Mita
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).