Re: [Cbe-oss-dev] [PATCH 1/4] spufs: clean up logic in spu_reacquire_runnable

[Christoph Hellwig <hch@lst.de>]

On Fri, Apr 13, 2007 at 11:48:58AM +1000, Jeremy Kerr wrote:
> spu_reacquire_runnable has an overly-complex way of calculating its
> return value. This change fixes it.
> 
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> 
>  arch/powerpc/platforms/cell/spufs/run.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> Index: linux-2.6-spufs/arch/powerpc/platforms/cell/spufs/run.c
> ===================================================================
> --- linux-2.6-spufs.orig/arch/powerpc/platforms/cell/spufs/run.c
> +++ linux-2.6-spufs/arch/powerpc/platforms/cell/spufs/run.c
> @@ -200,9 +200,7 @@ static inline int spu_reacquire_runnable
>  		       SPU_STATUS_STOPPED_BY_HALT)) {
>  		return *status;
>  	}
> -	if ((ret = spu_run_init(ctx, npc)) != 0)
> -		return ret;
> -	return 0;
> +	return spu_run_init(ctx, npc);

I have a patch that does this and some more cleanups in surrounding
code.  If you don't mind I'd like to drop this patch and promise to
send out my bigger patch ina few hours.