* [PATCH 1/4] spufs: clean up logic in spu_reacquire_runnable
@ 2007-04-13 1:48 Jeremy Kerr
2007-04-13 7:06 ` [Cbe-oss-dev] " Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Jeremy Kerr @ 2007-04-13 1:48 UTC (permalink / raw)
To: cbe-oss-dev, linuxppc-dev
spu_reacquire_runnable has an overly-complex way of calculating its
return value. This change fixes it.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
arch/powerpc/platforms/cell/spufs/run.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: linux-2.6-spufs/arch/powerpc/platforms/cell/spufs/run.c
===================================================================
--- linux-2.6-spufs.orig/arch/powerpc/platforms/cell/spufs/run.c
+++ linux-2.6-spufs/arch/powerpc/platforms/cell/spufs/run.c
@@ -200,9 +200,7 @@ static inline int spu_reacquire_runnable
SPU_STATUS_STOPPED_BY_HALT)) {
return *status;
}
- if ((ret = spu_run_init(ctx, npc)) != 0)
- return ret;
- return 0;
+ return spu_run_init(ctx, npc);
}
/*
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Cbe-oss-dev] [PATCH 1/4] spufs: clean up logic in spu_reacquire_runnable
2007-04-13 1:48 [PATCH 1/4] spufs: clean up logic in spu_reacquire_runnable Jeremy Kerr
@ 2007-04-13 7:06 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2007-04-13 7:06 UTC (permalink / raw)
To: Jeremy Kerr; +Cc: linuxppc-dev, cbe-oss-dev
On Fri, Apr 13, 2007 at 11:48:58AM +1000, Jeremy Kerr wrote:
> spu_reacquire_runnable has an overly-complex way of calculating its
> return value. This change fixes it.
>
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
>
> arch/powerpc/platforms/cell/spufs/run.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Index: linux-2.6-spufs/arch/powerpc/platforms/cell/spufs/run.c
> ===================================================================
> --- linux-2.6-spufs.orig/arch/powerpc/platforms/cell/spufs/run.c
> +++ linux-2.6-spufs/arch/powerpc/platforms/cell/spufs/run.c
> @@ -200,9 +200,7 @@ static inline int spu_reacquire_runnable
> SPU_STATUS_STOPPED_BY_HALT)) {
> return *status;
> }
> - if ((ret = spu_run_init(ctx, npc)) != 0)
> - return ret;
> - return 0;
> + return spu_run_init(ctx, npc);
I have a patch that does this and some more cleanups in surrounding
code. If you don't mind I'd like to drop this patch and promise to
send out my bigger patch ina few hours.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-04-13 7:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-13 1:48 [PATCH 1/4] spufs: clean up logic in spu_reacquire_runnable Jeremy Kerr
2007-04-13 7:06 ` [Cbe-oss-dev] " Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).