linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/4] spufs: Minor cleanup of spu_wait
@ 2007-04-13  1:48 Jeremy Kerr
  2007-04-13  7:07 ` [Cbe-oss-dev] " Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Jeremy Kerr @ 2007-04-13  1:48 UTC (permalink / raw)
  To: cbe-oss-dev, linuxppc-dev

Change the loop in spu_wait to be a little more straightforward.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

 arch/powerpc/platforms/cell/spufs/spufs.h |   13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

Index: linux-2.6-spufs/arch/powerpc/platforms/cell/spufs/spufs.h
===================================================================
--- linux-2.6-spufs.orig/arch/powerpc/platforms/cell/spufs/spufs.h
+++ linux-2.6-spufs/arch/powerpc/platforms/cell/spufs/spufs.h
@@ -218,14 +218,13 @@ extern char *isolated_loader;
 		prepare_to_wait(&(wq), &__wait, TASK_INTERRUPTIBLE);	\
 		if (condition)						\
 			break;						\
-		if (!signal_pending(current)) {				\
-			spu_release(ctx);				\
-			schedule();					\
-			spu_acquire(ctx);				\
-			continue;					\
+		if (signal_pending(current)) {				\
+			__ret = -ERESTARTSYS;				\
+			break;						\
 		}							\
-		__ret = -ERESTARTSYS;					\
-		break;							\
+		spu_release(ctx);					\
+		schedule();						\
+		spu_acquire(ctx);					\
 	}								\
 	finish_wait(&(wq), &__wait);					\
 	__ret;								\

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Cbe-oss-dev] [PATCH 2/4] spufs: Minor cleanup of spu_wait
  2007-04-13  1:48 [PATCH 2/4] spufs: Minor cleanup of spu_wait Jeremy Kerr
@ 2007-04-13  7:07 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2007-04-13  7:07 UTC (permalink / raw)
  To: Jeremy Kerr; +Cc: linuxppc-dev, cbe-oss-dev

On Fri, Apr 13, 2007 at 11:48:59AM +1000, Jeremy Kerr wrote:
> Change the loop in spu_wait to be a little more straightforward.

Looks good.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-04-13  7:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-13  1:48 [PATCH 2/4] spufs: Minor cleanup of spu_wait Jeremy Kerr
2007-04-13  7:07 ` [Cbe-oss-dev] " Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).