From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 18 Apr 2007 16:45:08 +1000 From: David Gibson To: Jerry Van Baren , linuxppc-dev@ozlabs.org, jdl@jdl.com Subject: Re: [PATCH: dtc] Improve -S handling Message-ID: <20070418064508.GC29312@localhost.localdomain> References: <20070418020535.GA16224@dellserver.lan> <20070418030528.GA27758@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070418030528.GA27758@localhost.localdomain> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Apr 18, 2007 at 01:05:28PM +1000, David Gibson wrote: > On Tue, Apr 17, 2007 at 10:05:35PM -0400, Jerry Van Baren wrote: > > If the user requests extra space, pad out the blob (previously the unused > > data was undefined). > > > > Signed-off-by: Gerald Van Baren > > --- > > > > Hi Jon, David, Milton, > > > > This improves the -S option to pad out the blob with zeros when the user > > asks for extra space. > > Comment below > > diff --git a/flattree.c b/flattree.c > > index 151d16e..d2ee0dc 100644 > > --- a/flattree.c > > +++ b/flattree.c > > @@ -310,6 +310,7 @@ static struct data flatten_reserve_list(struct reserve_info *reservelist, > > > > return d; > > } > > + > > static void make_bph(struct boot_param_header *bph, > > struct version_info *vi, > > int reservesize, int dtsize, int strsize, > > @@ -358,12 +359,15 @@ void dt_to_blob(FILE *f, struct boot_info *bi, int version, > > { > > struct version_info *vi = NULL; > > int i; > > + int size; > > struct data dtbuf = empty_data; > > struct data strbuf = empty_data; > > struct data reservebuf; > > struct boot_param_header bph; > > struct reserve_entry termre = {.address = 0, .size = 0}; > > > > + size = 0; > > + Oh, also, you shouldn't need this new variable to track the size. Just use whatever expression we used to use for totalsize before we forced it out to the minimum size. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson