From: David Gibson <david@gibson.dropbear.id.au>
To: Jerry Van Baren <gvb.uboot@gmail.com>
Cc: linuxppc-dev@ozlabs.org, jdl@jdl.com, u-boot-users@lists.sourceforge.net
Subject: Re: [PATCH: dtc take 2] Assemble the blob in memory before writing it out.
Date: Thu, 19 Apr 2007 12:05:20 +1000 [thread overview]
Message-ID: <20070419020520.GA4994@localhost.localdomain> (raw)
In-Reply-To: <20070419015951.GA9339@dellserver.lan>
On Wed, Apr 18, 2007 at 09:59:51PM -0400, Jerry Van Baren wrote:
> This makes padding out the blob if the user requested extra size much
> easer. The assembly and writing to the file is more straight forward too.
>
> Signed-off-by: Gerald Van Baren <vanbaren@cideas.com>
> ---
>
> Hi David, Jon,
>
> I wasn't happy with David's suggestion on the -S handling. I also wasn't
> all that wild about how the blob was assembled and then written to the
> file piecemeal with "ad-hoc" alignment padding. I realized I could fix
> both by assembling the blob in memory as a "struct data" and then write
> the whole thing out in one fell swoop.
>
> Makes it a lot simpler and cleaner to my eyes.
I like it. (In fact my original suggestion about using
data_append_zeroes() was based on a mistaken vague notion that we
already did it this way).
Acked-by: David Gibson <david@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2007-04-19 2:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-19 1:59 [PATCH: dtc take 2] Assemble the blob in memory before writing it out Jerry Van Baren
2007-04-19 2:05 ` David Gibson [this message]
2007-04-19 18:27 ` Jon Loeliger
2007-04-19 18:49 ` [U-Boot-Users] " Jerry Van Baren
2007-04-19 19:03 ` Jon Loeliger
2007-04-19 22:31 ` Jon Loeliger
2007-04-19 23:45 ` Jerry Van Baren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070419020520.GA4994@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=gvb.uboot@gmail.com \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=u-boot-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).