From: Christoph Hellwig <hch@infradead.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "<Andrew Morton" <akpm@osdl.org>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
containers@lists.osdl.org, Oleg Nesterov <oleg@tv-sign.ru>
Subject: Re: [PATCH] powerpc pseries eeh: Convert to kthread API
Date: Sun, 22 Apr 2007 13:31:55 +0100 [thread overview]
Message-ID: <20070422123155.GF20763@infradead.org> (raw)
In-Reply-To: <11769695763104-git-send-email-ebiederm@xmission.com>
On Thu, Apr 19, 2007 at 01:58:45AM -0600, Eric W. Biederman wrote:
> From: Eric W. Biederman <ebiederm@xmission.com>
>
> This patch modifies the startup of eehd to use kthread_run
> not a combination of kernel_thread and daemonize. Making
> the code slightly simpler and more maintainable.
This one has the same scheme as the various s390 drivers where a thread
is spawned using a workqueue on demand. I think we should not blindly
convert it but think a litte more about it.
The first question is obviously, is this really something we want?
spawning kernel thread on demand without reaping them properly seems
quite dangerous.
The second question is whether this is the right implementation.
kthread_create already works by using a workqueue to create the thread
and then waits for it. If we really want to support creating threads
asynchronously on demand we should have a proper API in kthread.c for
this instead of spreading workqueues.
next parent reply other threads:[~2007-04-22 12:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m1slawn9eb.fsf@ebiederm.dsl.xmission.com>
[not found] ` <11769695763104-git-send-email-ebiederm@xmission.com>
2007-04-22 12:31 ` Christoph Hellwig [this message]
2007-04-23 20:50 ` [PATCH] powerpc pseries eeh: Convert to kthread API Linas Vepstas
2007-04-24 1:38 ` Benjamin Herrenschmidt
2007-04-24 2:08 ` Eric W. Biederman
2007-04-24 2:42 ` Benjamin Herrenschmidt
2007-04-24 3:20 ` Eric W. Biederman
2007-04-24 4:34 ` Paul Mackerras
2007-04-24 4:51 ` Eric W. Biederman
2007-04-24 5:00 ` Benjamin Herrenschmidt
2007-04-24 5:43 ` Eric W. Biederman
2007-04-24 5:58 ` Benjamin Herrenschmidt
2007-04-24 6:17 ` SOME STUFF ABOUT REISER4 lkml777
2007-04-24 7:46 ` [PATCH] powerpc pseries eeh: Convert to kthread API Cornelia Huck
2007-04-24 17:24 ` Linas Vepstas
2007-04-24 5:55 ` Paul Mackerras
2007-04-24 8:37 ` Christoph Hellwig
2007-04-24 17:35 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070422123155.GF20763@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=containers@lists.osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=oleg@tv-sign.ru \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).