Re: [PATCH 1/4 v4] powerpc: document phy-connection-type property

[Kim Phillips <kim.phillips@freescale.com>]

On Mon, 23 Apr 2007 22:59:43 +0200
Segher Boessenkool <segher@kernel.crashing.org> wrote:

> > phy-connection-type is now maintained one-to-one with definitions
> > in include/linux/phy.h, albeit in the form of a string.
> 
> That's sort-of accidental though :-)
> 
sure..

> > --- a/Documentation/powerpc/booting-without-of.txt
> > +++ b/Documentation/powerpc/booting-without-of.txt
> > @@ -1562,6 +1562,9 @@ platforms are moved over to use the 
> > flattened-device-tree model.
> >       network device.  This is used by the bootwrapper to interpret
> >       MAC addresses passed by the firmware when no information other
> >       than indices is available to associate an address with a device.
> > +   - phy-connection-type : a string naming the controller/PHY 
> > interface type,
> > +     i.e., "mii" (default), "rmii", "gmii", "rgmii", "rgmii-id", 
> > "tbi",
> > +     or "rtbi".
> 
> Could you put this right after the "phy-handle" definition
> please?

phy-handle is a required property, whereas phy-connection-type is not
(it's recommended). Are you suggesting phy-connection-type be a required
property?

> 
> > @@ -1573,6 +1576,7 @@ platforms are moved over to use the 
> > flattened-device-tree model.
> >  		interrupts = <a0 0>;
> >  		interrupt-parent = <700>;
> >  		mac-address = [ 00 04 9f 00 23 23 ];
> > +		phy-connection-type = "gmii";
> >  		rx-clock = "none";
> >  		tx-clock = "clk9";
> >  		phy-handle = <212000>;
> 
> Same here.  It's nice to keep things grouped, it
> improves understanding ;-)

That's understandable.  Lemme know about the above though.

Kim