From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kim.phillips@freescale.com>
Received: from de01egw02.freescale.net (de01egw02.freescale.net
	[192.88.165.103])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "de01egw02.freescale.net",
	Issuer "Thawte Premium Server CA" (verified OK))
	by ozlabs.org (Postfix) with ESMTP id 90E44DDF1A
	for <linuxppc-dev@ozlabs.org>; Tue, 24 Apr 2007 07:06:29 +1000 (EST)
Date: Mon, 23 Apr 2007 16:06:21 -0500
From: Kim Phillips <kim.phillips@freescale.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: [PATCH 1/4 v4] powerpc: document phy-connection-type property
Message-Id: <20070423160621.329d1a08.kim.phillips@freescale.com>
In-Reply-To: <5c96dd623e3a6737db48ab17c3550610@kernel.crashing.org>
References: <20070423144052.261f68ad.kim.phillips@freescale.com>
	<5c96dd623e3a6737db48ab17c3550610@kernel.crashing.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Cc: linuxppc-dev@ozlabs.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

On Mon, 23 Apr 2007 22:59:43 +0200
Segher Boessenkool <segher@kernel.crashing.org> wrote:

> > phy-connection-type is now maintained one-to-one with definitions
> > in include/linux/phy.h, albeit in the form of a string.
> 
> That's sort-of accidental though :-)
> 
sure..

> > --- a/Documentation/powerpc/booting-without-of.txt
> > +++ b/Documentation/powerpc/booting-without-of.txt
> > @@ -1562,6 +1562,9 @@ platforms are moved over to use the 
> > flattened-device-tree model.
> >       network device.  This is used by the bootwrapper to interpret
> >       MAC addresses passed by the firmware when no information other
> >       than indices is available to associate an address with a device.
> > +   - phy-connection-type : a string naming the controller/PHY 
> > interface type,
> > +     i.e., "mii" (default), "rmii", "gmii", "rgmii", "rgmii-id", 
> > "tbi",
> > +     or "rtbi".
> 
> Could you put this right after the "phy-handle" definition
> please?

phy-handle is a required property, whereas phy-connection-type is not
(it's recommended). Are you suggesting phy-connection-type be a required
property?

> 
> > @@ -1573,6 +1576,7 @@ platforms are moved over to use the 
> > flattened-device-tree model.
> >  		interrupts = <a0 0>;
> >  		interrupt-parent = <700>;
> >  		mac-address = [ 00 04 9f 00 23 23 ];
> > +		phy-connection-type = "gmii";
> >  		rx-clock = "none";
> >  		tx-clock = "clk9";
> >  		phy-handle = <212000>;
> 
> Same here.  It's nice to keep things grouped, it
> improves understanding ;-)

That's understandable.  Lemme know about the above though.

Kim