* [PATCH] pasemi: Kconfig for mdio_gpio
@ 2007-04-24 17:58 Olof Johansson
2007-04-24 21:53 ` Arnd Bergmann
2007-04-24 23:17 ` [PATCH v2] pasemi: Kconfig for gpio_mdio Olof Johansson
0 siblings, 2 replies; 4+ messages in thread
From: Olof Johansson @ 2007-04-24 17:58 UTC (permalink / raw)
To: paulus; +Cc: linuxppc-dev, arnd
arch/powerpc/platforms/pasemi/gpio_mdio.c really depends on CONFIG_PHYLIB.
Add a config option for it, allow for it to be disabled if needed and fix
the dependency.
Signed-off-by: Olof Johansson <olof@lixom.net>
diff --git a/arch/powerpc/platforms/pasemi/Kconfig b/arch/powerpc/platforms/pasemi/Kconfig
index 64e5525..4b5f137 100644
--- a/arch/powerpc/platforms/pasemi/Kconfig
+++ b/arch/powerpc/platforms/pasemi/Kconfig
@@ -19,4 +19,12 @@ config PPC_PASEMI_IOMMU
help
IOMMU support for PA6T-1682M
+config PPC_PASEMI_MDIO
+ depends on PPC_PASEMI
+ bool "MDIO support via GPIO"
+ default y
+ select PHYLIB
+ help
+ Driver for MDIO via GPIO on PWRficient platforms
+
endmenu
diff --git a/arch/powerpc/platforms/pasemi/Makefile b/arch/powerpc/platforms/pasemi/Makefile
index e90265f..7ffd43b 100644
--- a/arch/powerpc/platforms/pasemi/Makefile
+++ b/arch/powerpc/platforms/pasemi/Makefile
@@ -1,2 +1,2 @@
-obj-y += setup.o pci.o time.o idle.o powersave.o iommu.o gpio_mdio.o
-
+obj-y += setup.o pci.o time.o idle.o powersave.o iommu.o
+obj-$(CONFIG_PPC_PASEMI_MDIO) += gpio_mdio.o
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pasemi: Kconfig for mdio_gpio
2007-04-24 17:58 [PATCH] pasemi: Kconfig for mdio_gpio Olof Johansson
@ 2007-04-24 21:53 ` Arnd Bergmann
2007-04-24 23:04 ` Olof Johansson
2007-04-24 23:17 ` [PATCH v2] pasemi: Kconfig for gpio_mdio Olof Johansson
1 sibling, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2007-04-24 21:53 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Olof Johansson, paulus
On Tuesday 24 April 2007, Olof Johansson wrote:
> +config PPC_PASEMI_MDIO
> +=A0=A0=A0=A0=A0=A0=A0depends on PPC_PASEMI
> +=A0=A0=A0=A0=A0=A0=A0bool "MDIO support via GPIO"
> +=A0=A0=A0=A0=A0=A0=A0default y
> +=A0=A0=A0=A0=A0=A0=A0select PHYLIB
> +=A0=A0=A0=A0=A0=A0=A0help
> +=A0=A0=A0=A0=A0=A0=A0 =A0Driver for MDIO via GPIO on PWRficient platforms
> +
Looks still wrong. I stumbled over the original bug because in fedora,
CONFIG_PHYLIB=3Dm. When you make PPC_PASEMI_MDIO a bool, it will
force PHYLIB=3Dy, which is potentially undesired.
Can you make this a modular driver (tristate)?
Instead of making it select PHYLIB directly, it might be more
straightforward to make PPC_PASEMI_MDIO depend on PHYLIB
and have the actual network driver select both PPC_PASEMI_MDIO
and PHYLIB.
Arnd <><
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pasemi: Kconfig for mdio_gpio
2007-04-24 21:53 ` Arnd Bergmann
@ 2007-04-24 23:04 ` Olof Johansson
0 siblings, 0 replies; 4+ messages in thread
From: Olof Johansson @ 2007-04-24 23:04 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linuxppc-dev, paulus
On Tue, Apr 24, 2007 at 11:53:06PM +0200, Arnd Bergmann wrote:
> On Tuesday 24 April 2007, Olof Johansson wrote:
> > +config PPC_PASEMI_MDIO
> > +???????depends on PPC_PASEMI
> > +???????bool "MDIO support via GPIO"
> > +???????default y
> > +???????select PHYLIB
> > +???????help
> > +??????? ?Driver for MDIO via GPIO on PWRficient platforms
> > +
>
> Looks still wrong. I stumbled over the original bug because in fedora,
> CONFIG_PHYLIB=m. When you make PPC_PASEMI_MDIO a bool, it will
> force PHYLIB=y, which is potentially undesired.
>
> Can you make this a modular driver (tristate)?
>
> Instead of making it select PHYLIB directly, it might be more
> straightforward to make PPC_PASEMI_MDIO depend on PHYLIB
> and have the actual network driver select both PPC_PASEMI_MDIO
> and PHYLIB.
Good points. New patch shortly.
-Olof
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] pasemi: Kconfig for gpio_mdio
2007-04-24 17:58 [PATCH] pasemi: Kconfig for mdio_gpio Olof Johansson
2007-04-24 21:53 ` Arnd Bergmann
@ 2007-04-24 23:17 ` Olof Johansson
1 sibling, 0 replies; 4+ messages in thread
From: Olof Johansson @ 2007-04-24 23:17 UTC (permalink / raw)
To: paulus; +Cc: linuxppc-dev, arnd
arch/powerpc/platforms/pasemi/gpio_mdio.c really depends on CONFIG_PHYLIB.
Add a config option for it, allow for it to be disabled if needed and fix
the dependency.
Signed-off-by: Olof Johansson <olof@lixom.net>
diff --git a/arch/powerpc/platforms/pasemi/Kconfig b/arch/powerpc/platforms/pasemi/Kconfig
index 64e5525..eb4dbc7 100644
--- a/arch/powerpc/platforms/pasemi/Kconfig
+++ b/arch/powerpc/platforms/pasemi/Kconfig
@@ -19,4 +19,11 @@ config PPC_PASEMI_IOMMU
help
IOMMU support for PA6T-1682M
+config PPC_PASEMI_MDIO
+ depends on PHYLIB
+ tristate "MDIO support via GPIO"
+ default y
+ help
+ Driver for MDIO via GPIO on PWRficient platforms
+
endmenu
diff --git a/arch/powerpc/platforms/pasemi/Makefile b/arch/powerpc/platforms/pasemi/Makefile
index e90265f..7ffd43b 100644
--- a/arch/powerpc/platforms/pasemi/Makefile
+++ b/arch/powerpc/platforms/pasemi/Makefile
@@ -1,2 +1,2 @@
-obj-y += setup.o pci.o time.o idle.o powersave.o iommu.o gpio_mdio.o
-
+obj-y += setup.o pci.o time.o idle.o powersave.o iommu.o
+obj-$(CONFIG_PPC_PASEMI_MDIO) += gpio_mdio.o
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-04-24 23:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-24 17:58 [PATCH] pasemi: Kconfig for mdio_gpio Olof Johansson
2007-04-24 21:53 ` Arnd Bergmann
2007-04-24 23:04 ` Olof Johansson
2007-04-24 23:17 ` [PATCH v2] pasemi: Kconfig for gpio_mdio Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).