From: Michael Buesch <mb@bu3sch.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Olof Johansson <olof@lixom.net>,
linuxppc-dev@ozlabs.org, egor@pasemi.com
Subject: Re: [PATCH] [2.6.22] pasemi: hardware rng driver
Date: Thu, 26 Apr 2007 11:23:57 +0200 [thread overview]
Message-ID: <200704261123.58032.mb@bu3sch.de> (raw)
In-Reply-To: <200704260138.32220.arnd@arndb.de>
On Thursday 26 April 2007 01:38:31 Arnd Bergmann wrote:
> On Wednesday 25 April 2007, Olof Johansson wrote:
>
> > +static void __iomem *rng_regs;
> > +
> > +static int pasemi_rng_data_present(struct hwrng *rng)
> > +{
> > + return (in_le32(rng_regs + SDCRNG_CTL_REG)
> > + & SDCRNG_CTL_FVLD_M) ? 1 : 0;
> > +}
>
> It would be nicer to get rid of the global rng_regs variable by sticking
> it into rng->priv.
Yeah, I think that would be better. Saves one global variable.
--
Greetings Michael.
next prev parent reply other threads:[~2007-04-26 9:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 20:45 [PATCH] [2.6.22] pasemi: hardware rng driver Olof Johansson
2007-04-25 23:38 ` Arnd Bergmann
2007-04-26 0:09 ` Olof Johansson
2007-04-26 9:23 ` Michael Buesch [this message]
2007-04-26 5:37 ` [PATCH v2] " Olof Johansson
2007-04-26 8:50 ` Arnd Bergmann
2007-04-26 20:59 ` [PATCH v3] " Olof Johansson
2007-04-26 9:22 ` [PATCH] " Michael Buesch
2007-04-26 20:46 ` Olof Johansson
-- strict thread matches above, loose matches on Subject: below --
2007-04-27 10:54 [PATCH 2.6.22] " Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704261123.58032.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=arnd@arndb.de \
--cc=egor@pasemi.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).