From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 30 Apr 2007 21:30:13 +1000 From: David Gibson To: Christoph Hellwig Subject: Re: powerpc: Remove arch/powerpc's dependence on asm-ppc/pg{alloc, table}.h Message-ID: <20070430113013.GE8725@localhost.localdomain> References: <20070430053723.GG6436@localhost.localdomain> <20070430063056.GB4683@localhost.localdomain> <20070430091846.GA15581@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070430091846.GA15581@lst.de> Cc: Paul Mackerras , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Apr 30, 2007 at 11:18:46AM +0200, Christoph Hellwig wrote: > On Mon, Apr 30, 2007 at 04:30:56PM +1000, David Gibson wrote: > > powerpc: Remove arch/powerpc's dependence on asm-ppc/pg{alloc,table}.h > > > > Currently, all 32-bit powerpc platforms use asm-ppc/pgtable.h and > > asm-ppc/pgalloc.h, even when otherwise compiled with ARCH=powerpc. > > Those asm-ppc files are a fairly nasty tangle of #ifdefs including a > > bunch of things which shouldn't be necessary any more in arch/powerpc. > > > > Cleaning up that mess is going to take a while, but this patch is a > > first step. It separates the asm-powerpc/pg{alloc,table}.h into 64 > > bit and 32 bit versions in asm-powerpc, which the basic .h files in > > asm-powerpc select based on config. We make a few tiny tweaks to the > > innards of the files along the way, making the outermost ifdefs > > (double-inclusion protection and __KERNEL__) a little cleaner, and > > #including asm-generic/pgtable.h from the top-level > > asm-powerpc/pgtable.h (since both the old 32-bit and 64-bit versions > > ended with such an #include). > > Nice cleanup. Btw, you can just kill the __KERNEL__ completely, > neither pgalloc.h nor pgtable are exported to userspace (as in > part of header-y or unifdef-y in include/asm-powerpc/Kbuild) Yes, Stephen pointed that out to me. I'll get to it... -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson