From: Kevin Corry <kevcorry@us.ibm.com>
To: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Cc: Stephane Eranian <eranian@hpl.hp.com>, Carl Love <carll@us.ibm.com>
Subject: [PATCH 0/2] powerpc: perfmon2 prereqs
Date: Wed, 2 May 2007 12:08:57 -0500 [thread overview]
Message-ID: <200705021208.59068.kevcorry@us.ibm.com> (raw)
Hi,
This is a repost of a couple patches I posted about a month ago related to
porting perfmon2 to powerpc. I wanted to see if there were any further
comments on these patches, and also wanted to ask if these should be
submitted separately to the ppc kernel maintainers, or if they should be kept
with the perfmon2 patches until those are submitted.
The first patch adds an smp_call_function_single() routine for powerpc. In
2.6.21, there's a prototype for this routine in include/linux/smp.h, and it
is implemented on i386, ia64, and x86-64. Since this routine is very similar
to the existing smp_call_function() routine, the common portions have been
pulled out into __smp_call_function(). Perfmon2 uses this unload a context
that's loaded on a CPU other than the one that's performing the close-context
routine.
The second patch changes the powerpc version of topology_init() from an
__initcall to a subsys_initcall, which matches the definition of
topology_init() on all other architectures. Perfmon2's initialization is done
as a subsys_initcall, but it fails to set up its sysfs information if
topology_init() has not yet run. Changing perfmon2 to an __initcall() was
discussed, but we came to the conclusion that this would not work because the
perfmon2 core must be initialized before any of its sub-modules. These
sub-modules are located in arch/*/perfmon/, and thus if they are built
statically they would run their module_init routines before the perfmon2 core
ran its __initcall routine.
We have been running tests with these patches for the last few weeks on Cell
and Power5 systems without any problems.
Thanks,
--
Kevin Corry
kevcorry@us.ibm.com
http://www.ibm.com/linux/
next reply other threads:[~2007-05-02 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 17:08 Kevin Corry [this message]
2007-05-02 17:10 ` [PATCH 1/2] powerpc: add smp_call_function_single() Kevin Corry
2007-05-02 17:11 ` [PATCH 2/2] powerpc: change topology_init() to a subsys_initcall Kevin Corry
2007-05-03 1:11 ` Michael Ellerman
2007-05-03 13:26 ` Kevin Corry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705021208.59068.kevcorry@us.ibm.com \
--to=kevcorry@us.ibm.com \
--cc=carll@us.ibm.com \
--cc=eranian@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).