From: Vitaly Bordug <vitb@kernel.crashing.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linuxppc-dev@ozlabs.org, linux-pcmcia@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [POWERPC] 8xx: mpc885ads pcmcia support
Date: Sun, 6 May 2007 03:27:47 +0400 [thread overview]
Message-ID: <20070506032747.07171caf@localhost.localdomain> (raw)
In-Reply-To: <20070504123543.5e3fd908.akpm@linux-foundation.org>
On Fri, 4 May 2007 12:35:43 -0700
Andrew Morton wrote:
> On Fri, 04 May 2007 03:57:51 +0400
> Vitaly Bordug <vitb@kernel.crashing.org> wrote:
>
> >
> > Adds support for PowerQuicc on-chip PCMCIA. The driver is
> > implemented as of_device, so only arch/powerpc stuff is capable to
> > use it, which now implies only mpc885ads reference board.
> >
> > To cope with the code that should be hooked inside driver, but is
> > really board specific (like set_voltage), global structure
> > mpc8xx_pcmcia_ops holds necessary function pointers that are filled
> > in the BSP code.
> >
>
> argh.
>
> akpm:/home/akpm> grep '^.* ' x | wc -l
> 72
>
> please, Linux uses hard-tabs, not
> spacespacespacespacespacespacespacespace everywhere.
>
Whoops. That must've survived being copypasted from the original m8xx_pcmcia.c.
That reminds me to do Lindent on the affected sources but that is subject for another patch.
Sorry for the hassle.
Apparently all the issues were correct, and I'll follow-up with the reworked patch. Thanks for looking at it.
--
Sincerely, Vitaly
next prev parent reply other threads:[~2007-05-05 23:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-03 23:57 [PATCH] [POWERPC] 8xx: mpc885ads pcmcia support Vitaly Bordug
2007-05-04 0:01 ` Arnd Bergmann
2007-05-04 19:35 ` Andrew Morton
2007-05-05 23:27 ` Vitaly Bordug [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-05-06 0:47 Vitaly Bordug
2007-05-06 1:04 ` Segher Boessenkool
2007-05-06 2:04 ` David Gibson
2007-05-06 9:48 ` Vitaly Bordug
2007-05-06 7:44 ` Vitaly Bordug
2007-05-06 13:26 ` Segher Boessenkool
2007-05-03 6:54 Vitaly Bordug
2007-05-03 7:48 ` Arnd Bergmann
2007-05-03 15:43 ` Segher Boessenkool
2007-05-03 19:03 ` Arnd Bergmann
2007-05-03 22:17 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070506032747.07171caf@localhost.localdomain \
--to=vitb@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).