From: Vitaly Bordug <vitb@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org, linux-pcmcia@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [POWERPC] 8xx: mpc885ads pcmcia support
Date: Sun, 6 May 2007 13:48:50 +0400 [thread overview]
Message-ID: <20070506134850.13689bf9@localhost.localdomain> (raw)
In-Reply-To: <20070506020427.GA22162@localhost.localdomain>
On Sun, 6 May 2007 12:04:27 +1000
David Gibson wrote:
> On Sun, May 06, 2007 at 03:04:14AM +0200, Segher Boessenkool wrote:
> > > + pcmcia@0080 {
> >
> > > + #interrupt-cells = <1>;
> >
> > > + interrupt-parent = <ff000000>;
> > > + interrupts = <d 1>;
> > > + };
> >
> > Since this node's children's interrupt representation
> > is different from the node's parent's, you need an
> > interrupt-map in here. You also forgot "#address-cells"
> > and I think you need "ranges" too?
>
> And we should use a reference, instead of an implicit phandle for the
> interrupt-parent.
>
I have one more patch for this - I think it makes sense to append it to the series...
Thinking it would be better to do the phandles->labels transition in one step for all the relevant
stuff in dts as well.
--
Sincerely, Vitaly
next prev parent reply other threads:[~2007-05-06 9:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-06 0:47 [PATCH] [POWERPC] 8xx: mpc885ads pcmcia support Vitaly Bordug
2007-05-06 1:04 ` Segher Boessenkool
2007-05-06 2:04 ` David Gibson
2007-05-06 9:48 ` Vitaly Bordug [this message]
2007-05-06 7:44 ` Vitaly Bordug
2007-05-06 13:26 ` Segher Boessenkool
-- strict thread matches above, loose matches on Subject: below --
2007-05-03 23:57 Vitaly Bordug
2007-05-04 0:01 ` Arnd Bergmann
2007-05-04 19:35 ` Andrew Morton
2007-05-05 23:27 ` Vitaly Bordug
2007-05-03 6:54 Vitaly Bordug
2007-05-03 7:48 ` Arnd Bergmann
2007-05-03 15:43 ` Segher Boessenkool
2007-05-03 19:03 ` Arnd Bergmann
2007-05-03 22:17 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070506134850.13689bf9@localhost.localdomain \
--to=vitb@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).