From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lixom.net (lixom.net [66.141.50.11]) by ozlabs.org (Postfix) with ESMTP id A0F11DDEB7 for ; Mon, 7 May 2007 13:54:48 +1000 (EST) Date: Sun, 6 May 2007 22:56:39 -0500 To: David Gibson Subject: Re: [PATCH 4/6] Device tree aware EMAC driver Message-ID: <20070507035639.GA5567@lixom.net> References: <20070504055455.GA25922@localhost.localdomain> <20070507003019.GB16165@localhost.localdomain> <20070507005723.GA4453@lixom.net> <20070507014051.GF16165@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070507014051.GF16165@localhost.localdomain> From: olof@lixom.net (Olof Johansson) Cc: linuxppc-dev@ozlabs.org, Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, On Mon, May 07, 2007 at 11:40:51AM +1000, David Gibson wrote: > On Sun, May 06, 2007 at 07:57:23PM -0500, Olof Johansson wrote: > > On Mon, May 07, 2007 at 10:30:19AM +1000, David Gibson wrote: > > > This is BenH's rewritten, device tree aware driver for the IBM/AMCC > > > EMAC, ethernet MAC controller ASIC found on various 4xx CPUs and also > > > the Axon bridge. Tweaked to build on current kernels. > > > > Shouldn't benh have a signoff line on it as well in that case? > > Well, his patch which I tweaked didn't have his signoff, so I didn't > think I ought to add it. Heh, ok. > > Is it ibm_emac or ibm_newemac? All file headers say ibm_emac, and there's > > still Kconfig references to ibm_emac. > > It's ibm_newemac, the file headers just haven't been updated. The > Kconfig changes referring to ibm_emac are just because the patch moves > the suboptions for the old emac driver into their own subdirectory, > and it inhibits selecting the old emac driver in arch/powerpc. Hm, so it both modifies the old driver and adds the new one? Is the plan to have both of them in parallel? Sounds wasteful, but I guess it'll be hard to avoid until 4xx is dead in arch/ppc. > > (Is this just posted FYI? If not, it should really go to netdev/jgarzik > > instead, right?) > > This is just FYI at the moment, or rather, it's not really an Ebony > related patch but it's in this series because the Ebony support is > much more interesting if the ethernet works. Ok. It really sucks trying to review patches of this size, but I'll try to make a few passes over it. It'd be useful to just see the incremental steps of how it was morphed from the current driver, but that's a pain to recreate once you have this kind of blob. Especially if you inherited the bulk of it. :-) -Olof