From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pentafluge.infradead.org (pentafluge.infradead.org [213.146.154.40]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id A67C7DDE36 for ; Tue, 8 May 2007 22:16:08 +1000 (EST) Date: Tue, 8 May 2007 13:15:27 +0100 From: Christoph Hellwig To: Thomas Klein Subject: Re: [PATCH] ehea: Receive SKB Aggregation Message-ID: <20070508121527.GA16763@infradead.org> References: <200705081405.33742.osstklei@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <200705081405.33742.osstklei@de.ibm.com> Cc: Thomas Klein , Jeff Garzik , Jan-Bernd Themann , netdev , linux-kernel , Christoph Raisch , Stefan Roscher , linux-ppc , Marcus Eder List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, May 08, 2007 at 02:05:33PM +0200, Thomas Klein wrote: > This patch enables the receive side processing to aggregate TCP packets within > the HEA device driver. It analyses the packets already received after a > interrupt arrived and forwards these as a chains of SKBs for the same TCP > connection with modified header field. We have seen a lower CPU load and > improved throughput for small numbers of parallel TCP connections. > > We added a disabled module parameter to prevent disruption of normal driver > operation. > We currently consider this as "experimental" until further review and tests > have been passed. > > Are there any concerns about including this in the mainline driver? So we grow yet another LRO copy in drivers? I think someone needs to bite the bullet and make it generic.